search

ArtifexSoftware / pdf2docx

Open source Python library for converting PDF to DOCX.
https://pdf2docx.readthedocs.io
GNU Affero General Public License v3.0
2.46k stars 356 forks source link

Adjustments for upstream upgrades #253

Closed dothinking closed 7 months ago

dothinking commented 7 months ago

Some adjustments to handle the side effects of upgrading PyMuPDF from 1.23.8 to 1.23.14+, e.g.,

And some other tweaks, e.g., remove Github Action for publishing docs to Github page.

JorjMcKie commented 7 months ago

A fix is identified already and will lead to a new PyMuPDF version - hopefully even today.

jamie-lemon commented 7 months ago

Thanks Train! ( hope you don't me calling you "Train" - seen you use it a few times, please let me know ) . It is possible that we will have fixed some of the issues you are seeing in an imminent release of PyMuPDF.

Adding Harald & Julian here as they should be aware of the behaviour change for Rect & Pixmap - I think we know about the Pixmap one already. I guess if the issues are both fixed in PyMuPDF 1.23.16 then you may want to rework this PR. @JorjMcKie , @julian-smith-artifex-com What do you think?

dothinking commented 7 months ago

@jamie-lemon "Train" sounds friendly for me, as it's a name used in my college time. 😁

Regarding this PR, once released PyMuPDF 1.23.16, I just need to delete the version restriction in requirements.txt, the rest should be OK.

julian-smith-artifex-com commented 7 months ago

FYI, PyMuPDF-1.23.16 has just been released, and fixes the Pixmap issue https://github.com/pymupdf/PyMuPDF/issues/3058.

The fitz.Rect problem was introduced in 1.23.9 and fixed in 1.23.13 and later.

Hope that helps.