search

ArtificialQualia / PyEveLiveDPS

PyEveLiveDPS (PELD) is a live DPS calculator and grapher for EVE Online
GNU General Public License v3.0
160 stars 27 forks source link

Internal Code Redesign/Cleanup #13

Closed ArtificialQualia closed 7 years ago

ArtificialQualia commented 7 years ago

As we add more lines, more features, more code, the current code base needs to be fixed to handle all these different cases better. Too many objects are being passed to class constructors and objects saved in 'improper' scopes (at least I don't use globals!), and functions need to be made to handle these lines generically.

The current methods are ok when we only had two lines. As we start approaching 6-7 lines we need to handle this better!

Also the settings window needs to be moved out of the other window class. It too has exploded to the point where it needs it's own class and file, especially as we move to file i/o operations with persistent settings.

Ideally when we are handling this correctly and generically, ALL lines will follow the model of the DPS lines with configurable threshold settings, and any line can be enabled/disabled.

ArtificialQualia commented 7 years ago

Some cleanup remains but major overhauls have been made