Artikash / Textractor

Extracts text from video games and visual novels. Highly extensible.
GNU General Public License v3.0
2.09k stars 203 forks source link

Textractor hooks the text, but is ignoring certain punctuations. #1016

Closed Vincent-Dawn closed 1 year ago

Vincent-Dawn commented 1 year ago

With the game I'm playing (https://vndb.org/v10294), Textractor has no problem hooking Japanese characters, but it's not hooking ellipses and dashes for some reason. I know this might be a minor issue, but I feel the lack of these might mess up how a sentence is translated.

Also when I attach the game and it lists the hooks it's ignoring and not finding certain hooks like these:

vnreng:NekoPack: pattern not found vnreng: IGNORE Nya NNNConfig

Vincent-Dawn commented 1 year ago

@Blu3train

I played a bit more after posting this message and I noticed some other issues Textractor is having with this game aside from the punctuations.

Sometimes the character that is speaking's name will randomly appear outside of the brackets (either before or after the sentence) and may sometimes appear in the middle of the sentence.

The only time spaces appear is when a character is talking, but not with the narration. Aside from periods, commas, and exclamation points it will not hook ellipses or dashes specifically. Here is an example of what I'm talking about:

Screenshot 2023-03-13 202730 Screenshot 2023-03-13 202757

Blu3train commented 1 year ago

I deleted my answer because I installed the game and saw that the characters are really missing and therefore there is nothing you can do but find a working hook. Tried looking for a better hook. I managed to find one where the missing characters appeared but the text repeated many times and couldn't filter properly so I gave up. Maybe someone better than me at looking for hooks can help you.

Vincent-Dawn commented 1 year ago

I found another game by Cyclet and the problems mentioned in the previous game appear to be present in other games made by that company. I assume NekoPack is the engine they use for those games, which isn't recognized by Textractor, but can still hook the main text.