Artikash / Textractor

Extracts text from video games and visual novels. Highly extensible.
GNU General Public License v3.0
2.14k stars 205 forks source link

Menu choices text hooked/translated as a single sentence #267

Open perv-asive opened 4 years ago

perv-asive commented 4 years ago

In RPGMaker MV games (and maybe others, haven't tested all engines), it seems like the different actions in the list will be hooked in a single string together with any dialogue/description/story. Also sometimes the text of the actions list is repeated but the Repeated Phrases extension doesn't catch it. image

In this example the translation is still pretty understandable, but in more complicated cases the translations can reverse the order of things or get it wrong where one choice ends and the next begins.

Is there a way the hooker could separate each action choice onto a separate line?

perv-asive commented 4 years ago

image Here is an example where the translation makes it completely unclear which choice is which.

Artikash commented 4 years ago

There are ways to fix this, but none of them are pretty. Is it not good enough that you can copy paste from Textractor into https://translate.google.com?

perv-asive commented 4 years ago

Copy and paste into Google translate is what I've been doing, but having to do that for every choice is annoying enough that the game pretty much stops being fun IMO. :/

Artikash commented 4 years ago

When you select the automatically found text thread that contains the game text, the top right dropdown should end with (HQX-8@<some hex number>:<module>). <module> will probably be either Game.exe, node.dll, or nw.dll, but in any case try adding this hook code, replacing <module> with the one in Textractor: HQFB+-8*0@0:<module>:?Write@String@v8@@QBEHPAGHHH@Z