Artillex-Studios / AxGraves

A lightweight grave (death chest) plugin focused on performance & compatbility
MIT License
13 stars 3 forks source link

Display anomalies and data loss #4

Closed YouaJing closed 8 months ago

YouaJing commented 10 months ago

I’ve found some issues during testing on the Folia1.20.1

After players switch worlds, they are unable to see the Grave. Using /reload only reloads the hologram and not the skull entity. When players exit the game and re-enter the server, normal display is restored. Grave data is only temporarily run within the server, with no local backup data. When the server crashes or the admin restarts the server, any Graves that are still counting down will be cleared, and player items will be permanently lost.

e05d1f0b828870e6a4b9aeb347cf05a

image

BenceX100 commented 9 months ago

Hello, can you check the latest version?

YouaJing commented 9 months ago

Using the latest releases, the problem still persists.

I suggest the following areas for improvement: ①Re-render the scene after switching worlds ②Store the data in SQLite, MySQL when each player dies, and delete it when the player collects items or the timer expires, and load the local data when the server initializes the plugin.

AverageGithub commented 9 months ago

Hi, about the first issue, we do resend packet entities on world change, but I don't think that event is called on Folia, as I don't think any teleport events are called on it, (for example: respawn event, teleport event).