Artoria2e5 / GDJ

Gdi32 & DirectWrite Jammer
https://arthur2e5.github.io/GDJ
GNU Lesser General Public License v2.1
0 stars 0 forks source link

Feature Request: MinHeight setting #89

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
This not a bug report but a feature request. I have noticed that disabling 
hinting looks better than hinted fonts for high DPI monitors and normal size 
fonts, but small fonts (<=9pt) require hinting for greater readability.  So 
perhaps we can get a MinHeight setting that would have gdipp only render fonts 
that are bigger than the setting?

Original issue reported on code.google.com by greatq...@gmail.com on 13 Jul 2010 at 12:32

GoogleCodeExporter commented 8 years ago
Reasonable request. However, instead of introducing a new setting item, I would 
like to reuse the existing "max_height" item, and move it to selector nodes' 
optional parameter, so that you can use the following example:

<font name=".*" max_height="9">
  <hinting>1</hinting>
</font>

<font name=".*" max_height="72">
  ...
  <hinting>0</hinting>
</font>

here all fonts whose height is <= 9 will be matched in the first selector node, 
and thus the hinting is enabled. Since it is already matched, the hinting 
setting in the second node will be ignored. Otherwise if the font's height is > 
9, only the second node is matched, and hinting is disabled.

Original comment by crendk...@gmail.com on 13 Jul 2010 at 3:20

GoogleCodeExporter commented 8 years ago
Note that this is not the final design. Please refer to the SETTING 
documentation before editing your setting file.

Original comment by crendk...@gmail.com on 13 Jul 2010 at 3:25

GoogleCodeExporter commented 8 years ago
First of all - congratulations on version 0.9.  The rendering, font spacing, 
everything is so much better.  Just wanted to know if this feature was included 
-- I tried putting this section 

        <font max_height="9">
            <hinting>1</hinting>
        </font>

before the included default max_height=72 section, but I'm not convinced it is 
working. Should it be?

Original comment by greatq...@gmail.com on 24 Aug 2010 at 3:41

GoogleCodeExporter commented 8 years ago

Original comment by crendk...@gmail.com on 29 Aug 2010 at 8:59

GoogleCodeExporter commented 8 years ago
It is actually working, but the "height" here is the cell height (including 
ascending and descending), not the character height. So in Notepad, the 10pt 
Segoe UI's cell height is actually 17 units. So if you want to limit 9pt fonts 
in 0.9.0, you need to put number around 15. Refer 
http://msdn.microsoft.com/en-us/library/dd145037%28VS.85%29.aspx for more 
information about font height. I may switch the "height" concept to point size 
in 0.9.1. Pay attention to the ChangeLog.

Original comment by crendk...@gmail.com on 29 Aug 2010 at 9:10