search

Artoriuz / ArtCNN

Super-Resolution Convolutional Neural Networks as GLSL shaders for mpv
MIT License
109 stars 2 forks source link

it seem to have issues with rigning. #5

Closed mightyhuhn closed 7 months ago

mightyhuhn commented 7 months ago

test file: sd.zip results: https://slow.pics/c/X8waASMt all NN scaler fail here. so this filter is not an outliner. edit: fixed one image.

Artoriuz commented 7 months ago

If you still end up having issues with ringing when actually using the shader just be reminded that it has built-in AR which you can control with --glsl-shader-opts (or edit the default value in the shader body itself).

mightyhuhn commented 7 months ago

only 1 image was wrong. they all ringing now. i was testing all mode in 16 to be fair and mistyped for sh. the comparisons will be in the opening post.

the casual 0.35 below? //!PARAM ar_strength //!TYPE float //!MINIMUM 0.0 //!MAXIMUM 1.0

Artoriuz commented 7 months ago

Yeah it's set very low by default to prevent hurting fine detail generation, but you can crank it up to get rid of ringing if the ringing is coming from the model.

mightyhuhn commented 7 months ago

even at 1 it has barely any effect on this image. i used this to change it:

CTRL+5 change-list glsl-shader-opts set "ar_strength=1"; CTRL+6 change-list glsl-shader-opts set "ar_strength=0"; it changes something so it should be the correct usage.

Artoriuz commented 7 months ago

That's because the ringing is in the source.

This is literally how it looks like without any scaling: Screenshot 2024-02-02 174359

mightyhuhn commented 7 months ago

i know the source has ringing alot of ringing typical anime dvd. if a NN scaler adds ringing where a dumb scaler doesn't that's the issue here the major example: 16mini jinc mini

16mini300 jinc mini300

Artoriuz commented 7 months ago

The normal FIR filter is just blurring the ringing out, the CNNs are respecting the content.

I could train a variant of ArtCNN to get rid of source ringing though.

mightyhuhn commented 7 months ago

well i guess so NN is not really ringing they don't work like jinc here in comparison. but i simply can not agree that this is respecting the content in this case this is not source ringing and the NN scaler are just smoothing it over.

if i look at the normal sized x2 image i see a black bar on the middle of the white letters. objectively it there is no black bar it is just a little bit darker.

most likely just an edge case here it looks wrong. i don't know the correct term.