ArtsiomCh / CMake

IntelliJ Platform plugin for CMake basic syntax highlight.
https://plugins.jetbrains.com/plugin/10089-cmake-simple-highlighter
GNU General Public License v3.0
44 stars 7 forks source link

Problem with Syntax Highlight of CMake Variable Reference #62

Closed tvp-naubry closed 4 months ago

tvp-naubry commented 5 months ago

There is a visual conflict problem with CMake variables in themes with high contrast (presumably the JetBrains Dark Mode theme is not affected).

Disabling the CMake Plus / CMake simple highlighter plugin makes the problem disappear.

Here is an example of what I get with a CMake variable using the "One Dark Vivid" theme: CleanShot 2024-03-14 at 13 25 29@2x CleanShot 2024-03-14 at 13 28 00@2x

I'm not sure if this is a plugin issue, but if anyone has encountered the same problem and found a solution, I would be grateful!

tvp-naubry commented 5 months ago

Note: I don't seem to have the problem on Windows. I found the problem on my MacBook Pro (macOS Sonoma).

EDIT: I have the same problem on Windows. I had the CMake Plus plugin deactivated and hadn't noticed this. Probably a bad synchronization of my IDE settings... So sorry for the wrong indication: the problem occurs on macOS and Windows.

ArtsiomCh commented 4 months ago

Thanks for reporting! Reproduced with One Dark Theme. Will try to produce fix soon. For now use next workaround: set the same color (font and it attributes could be different) for "CMake variable reference" and "Local variable reference" in

Settings > Editor > Color Scheme > CMake additional syntax

image

ArtsiomCh commented 4 months ago

Fixed in upcoming 241.1.1 version Thanks again for reporting!