search

ArturKalach / react-native-a11y

A11y Library for RN
MIT License
41 stars 5 forks source link

FocusWrapperProps should not have required props #45

Closed ckknight closed 8 months ago

ckknight commented 10 months ago

In https://github.com/ArturKalach/react-native-a11y/blob/d9d55bde8c11465620de612e8683f9f6c6b8f30c/src/components/KeyboardFocusView/RCA11yFocusWrapper/RCA11yFocusWrapper.types.ts#L22-L23, both onKeyUpPress and onKeyDownPress are both required properties.

They should be optional (and the components work as expected when they are optional).

Documentation within README.md already specifies that these are optional.

ArturKalach commented 10 months ago

Hello @ckknight, Thank you for creating the issue and highlighting this. It help me move forward) I am update this in some days. Unfortunately, I don't have possibility nor resourcces to polish this lib, I mean that projects I am working on don't use it and I don't have enough test cases(

If you need any additional functionality or have ideas what can be added to the lib, feel free to share it. I have ideas, but not sure what whould be better to implement first, or whether it is really needed)

ArturKalach commented 10 months ago

Hello @ckknight, I fixed this issue and added some additional changes. I created release candidate: https://www.npmjs.com/package/react-native-a11y/v/0.4.3-rc and want to check it with different platforms and architecture. It can take some time, but I hope it will be finished this month.

Thank you for a help. Artur Kalach

ArturKalach commented 8 months ago

Has been resolved in v.0.4.3.