ArturSierzant / OMPD

O!MPD is free, opensource MPD client based on PHP and mySQL.
http://ompd.pl
GNU General Public License v3.0
40 stars 13 forks source link

Qobuz Integration #105

Open marcbth opened 5 years ago

marcbth commented 5 years ago

Hello Artur,

would it be a relief if I would integrate qobuz based on your tidal integration. to prepare all files incl database on qobuz?

cliff

marcbth commented 5 years ago

Hello Artur,

please look at my fork. I started to integrate qobuz. Of course it is not finished yet. I still have some problems (am a beginner). What would be nice, would be the beginning of the integration per upmpdcli. Everything else can then be seen. Since you can not access qobuz, I can offer you a vpn and qobuz.

I hope I do not shoot beyond the goal. please write me a private mail. I would like to support you too

cliff

ArturSierzant commented 5 years ago

I took a look at your work. At first it didn't work at all - I found you duplicated functions names in library.inc.php: formatBio() and showArtistBio(). When I changed it to unique names, O!MPD started.

It looks like you are trying to copy 1:1 Tidal functions to Qobuz functions. I'm afraid it will not work. Qobuz uses different API then Tidal: for example authentication requires app_id, which is not present in Tidal. Besides, returned data structure for given query (e.g. for artist or album) is also different. So there is a lot of work, but keep working - it would be nice if O!MPD could work with Qobuz.

Artur

marcbth commented 5 years ago

Many thanks for your response.

My approach is, as you write, to create a 1 to 1 copy of tidal. I also have problems with the if statements. Maybe you can help me with that.

in the beginning it would be nice if the connection would go through upmpdcli.

Do you already know https://notabug.org/Aesir/chimera

maybe helpful for other services.

what do you think of adding a menu item with tidal (see menu structure of upmpdcli).

I'm just trying to shed light on your wonderful work.

cliff

ArturSierzant commented 5 years ago

The problem with if statement is that you use multiple else. It should look like this:

if
elseif
else

and you have:

if
else
else

I found it in ajax-album-playlist.php

marcbth commented 5 years ago

Many thanks, I will correct this

marcbth commented 5 years ago

It would be nice if you could help me. am still learning php. I want to support you as far as my skills go.

can you please write me a private mail. I want to send you something.

did you speak German?

cliff

ArturSierzant commented 5 years ago

If I'll be able to help, I will try. But I'm not a php master, I also learn it all the time. And I often lack time - that's why I answer late. I don't know your private mail, you can write me to info@ompd.pl And I'm sorry, I don't speak German (I wish I could).