Latest version (git pull) gives lighttpd errors

[maartenlangeveld]

Latest version (git pull) gives lighttpd errors:

2023-12-11 16:19:24: (mod_fastcgi.c.449) FastCGI-stderr:PHP message: PHP Fatal error:  Uncaught ValueError: strpos(): Argument #3 ($offset) must be contained in argument #1 ($haystack) in /var/www/ompd/include/library.inc.php:273
2023-12-11 16:19:24: (mod_fastcgi.c.449) FastCGI-stderr:Stack trace:
2023-12-11 16:19:24: (mod_fastcgi.c.449) FastCGI-stderr:#0 /var/www/ompd/include/library.inc.php(273): strpos()
2023-12-11 16:19:24: (mod_fastcgi.c.449) FastCGI-stderr:#1 /var/www/ompd/play.php(2279): findCoreTrackTitle()
2023-12-11 16:19:24: (mod_fastcgi.c.449) FastCGI-stderr:#2 /var/www/ompd/play.php(77): playlistTrack()
2023-12-11 16:19:24: (mod_fastcgi.c.449) FastCGI-stderr:#3 {main}
2023-12-11 16:19:24: (mod_fastcgi.c.449) FastCGI-stderr:  thrown in /var/www/ompd/include/library.inc.php on line 273
2023-12-11 16:19:24: (mod_fastcgi.c.449) FastCGI-stderr:PHP message: PHP Fatal error:  Uncaught ValueError: strpos(): Argument #3 ($offset) must be contained in argument #1 ($haystack) in /var/www/ompd/include/library.inc.php:273
2023-12-11 16:19:24: (mod_fastcgi.c.449) FastCGI-stderr:Stack trace:
2023-12-11 16:19:24: (mod_fastcgi.c.449) FastCGI-stderr:#0 /var/www/ompd/include/library.inc.php(273): strpos()
2023-12-11 16:19:24: (mod_fastcgi.c.449) FastCGI-stderr:#1 /var/www/ompd/play.php(2279): findCoreTrackTitle()
2023-12-11 16:19:24: (mod_fastcgi.c.449) FastCGI-stderr:#2 /var/www/ompd/play.php(77): playlistTrack()
2023-12-11 16:19:24: (mod_fastcgi.c.449) FastCGI-stderr:#3 {main}
2023-12-11 16:19:24: (mod_fastcgi.c.449) FastCGI-stderr:  thrown in /var/www/ompd/include/library.inc.php on line 273

[ArturSierzant]

Thanks for reporting that. I think the error is caused by a track which length of title is 1. Was one on your playlist? In commit e5e2765 I fixed it, I guess. Please check if it works in your case.

[maartenlangeveld]

Hi @ArturSierzant Thanks for your reply. The error occurs irrespective of title length or playlist items. Despite te latest commit, the error still occurs.

2023-12-13 11:26:44: (mod_fastcgi.c.449) FastCGI-stderr:PHP message: PHP Fatal error:  Uncaught ValueError: strpos(): Argument #3 ($offset) must be contained in argument #1 ($haystack) in /var/www/ompd/include/library.inc.php:276
2023-12-13 11:26:44: (mod_fastcgi.c.449) FastCGI-stderr:Stack trace:
2023-12-13 11:26:44: (mod_fastcgi.c.449) FastCGI-stderr:#0 /var/www/ompd/include/library.inc.php(276): strpos()
2023-12-13 11:26:44: (mod_fastcgi.c.449) FastCGI-stderr:#1 /var/www/ompd/play.php(2279): findCoreTrackTitle()
2023-12-13 11:26:44: (mod_fastcgi.c.449) FastCGI-stderr:#2 /var/www/ompd/play.php(77): playlistTrack()
2023-12-13 11:26:44: (mod_fastcgi.c.449) FastCGI-stderr:#3 {main}
2023-12-13 11:26:44: (mod_fastcgi.c.449) FastCGI-stderr:  thrown in /var/www/ompd/include/library.inc.php on line 276
2023-12-13 11:26:44: (mod_fastcgi.c.449) FastCGI-stderr:PHP message: PHP Fatal error:  Uncaught ValueError: strpos(): Argument #3 ($offset) must be contained in argument #1 ($haystack) in /var/www/ompd/include/library.inc.php:276
2023-12-13 11:26:44: (mod_fastcgi.c.449) FastCGI-stderr:Stack trace:
2023-12-13 11:26:44: (mod_fastcgi.c.449) FastCGI-stderr:#0 /var/www/ompd/include/library.inc.php(276): strpos()
2023-12-13 11:26:44: (mod_fastcgi.c.449) FastCGI-stderr:#1 /var/www/ompd/play.php(2279): findCoreTrackTitle()
2023-12-13 11:26:44: (mod_fastcgi.c.449) FastCGI-stderr:#2 /var/www/ompd/play.php(77): playlistTrack()
2023-12-13 11:26:44: (mod_fastcgi.c.449) FastCGI-stderr:#3 {main}
2023-12-13 11:26:44: (mod_fastcgi.c.449) FastCGI-stderr:  thrown in /var/www/ompd/include/library.inc.php on line 276

[ArturSierzant]

OK, next attempt in aaffdeb For unknown reasons I can't reproduce this error at will. I use nginx and when this error appears I see in log that it begins with call like this: play.php?action=playlistTrack&track_id=undefined&menu=playlist&ajax=1 I think the reason is _trackid=undefined. For now I don't known why it is undefined, but I modified playlistTrack() to handle this. Please give it a try.

[maartenlangeveld]

Hello Arthur,

Thanks for your help. Problem still occurs. Error is logged when emtpy playlist and selecting 'Library'.

Maybe that gives some guidance?

kind regards, Maarten

On Wed, 13 Dec 2023 21:52:50 +0100, Artur Sierżant @.***> wrote:

OK, next attempt in aaffdeb For unknown reasons I can't reproduce this error at will. I use nginx and when this error appears I see >in log that it begins with call like this: play.php?action=playlistTrack&track_id=undefined&menu=playlist&ajax=1I think the reason is track_id=undefined. For now I don't known why it is undefined, but I modified >playlistTrack() to handle this. Please give it a try.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

[ArturSierzant]

Yes, it was very helpful. I hope commit 62922be finally fixes this issue.

[maartenlangeveld]

Hi Artur,

Thanks, it helped, no errors anymore!

Maarten

On Mon, 18 Dec 2023 20:19:20 +0100, Artur Sierżant @.***> wrote:

Yes, it was very helpful. I hope commit 62922be finally fixes this issue.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

[ArturSierzant]

Great :) So I'm closing this issue. Thanks again for reporting.