ArturoAmaya / ExploratoryCurricularAnalytics

Scripts to convert UCSD Curriculum information from UCSD format into Curricular Analytics format.
1 stars 3 forks source link

HI25 still too short #21

Closed ArturoAmaya closed 2 years ago

ArturoAmaya commented 2 years ago

I figure this happens elsewhere too, but this is the representative example I stumbled on. Currently I'm messing around with a list of planned courses for the curriculum and I'm still getting an undercount of courses. There are supposed to be 15 major courses for history (3 LD and 12 UD). My count tops out at 13.

I'm missing a HILD and an HIUD (that one is unclear which quarter at the moment). Currently investigating.

ArturoAmaya commented 2 years ago

Sorry, I thought I had just committed an egregious mistake counting from 1 to 15.

The major plan for TH has 13 total courses instead of the expected 15. Precisely the missing HIUD courses are the ones in year 3 quarters 1 and 2 where there are two HIUD courses per quarter on the plan and only one per quarter in the major_codes["HI25"].plans["TH"].

Issue is also observable with GEs. Year 1 quarter 1 specifies 2 GE courses but the script only picks up 1.

ArturoAmaya commented 2 years ago

Will now attempt to replicate with 3 other majors to "confirm" a system issue and not a freak accident.

ArturoAmaya commented 2 years ago

Showed it happens exactly the same with: GL25, HI25, HS25 for Marshall and HS25 for Warren (only ones tested so far). Screenshot (326) This is Marshall HI25. The plan calls for 15 courses for the major but there are only 13. In the upper pane you'll see that quarter 1 only has 1 GE, whereas our sheets and csv call for two.

Screenshot (327) This is Marshall HDS25. Each quarter has less classes than they're supposed to. Quarter 1 has only one LD Major Prep, as does quarter 2. Quarter 3 has one less GE than called for as does quarter 4.

Screenshot (329) Same issue with GL25. Three GEs in quarter 1 get condensed into 1, two GEs in quarter 2 get condensed into one, same in quarter 3, and an elective disappears in quarter 4.

Screenshot (330) Same with HDS25 but in Warren. 2 'LD Major Prep's become one in quarters 1 and 2, and a GE disappears in quarter 3.

Will look into why that happens.

SheepTester commented 2 years ago

Duplicate courses might be being swallowed up by sets as you noticed in #19

With that fixed it now has 15 courses

image

ArturoAmaya commented 2 years ago

Yup, is all good now.