search

Arturus / kaggle-web-traffic

1st place solution
MIT License
1.82k stars 667 forks source link

Question about .params_size() in model.py #24

Closed H0bbitBaron closed 5 years ago

H0bbitBaron commented 6 years ago

Hello @Arturus ! Firstly thank you for sharing your code and congratulations with the first place)

I'm digging code and stuck on this few lines - https://github.com/Arturus/kaggle-web-traffic/blob/master/model.py#L72

Can you please clarify what is params_size? As stated in TF docs it returns "size of the opaque parameter buffer". The hell is this - hyperparameter size/memory limit/batch size that can fit into my particular GPU memory?

And leading question - why do we need to check the values of the two returns of the one same function build_rnn?

Thank you in advance!

amirkhango commented 5 years ago

Good question. I am also curious. Have you done it?

Arturus commented 5 years ago

Model is fixed to work with TF 1.10, params_size magic is redundant for modern Tensorflow and was removed.