search

Arturus / kaggle-web-traffic

1st place solution
MIT License
1.82k stars 667 forks source link

holidays is not used in the finally version? #9

Closed shadowwider closed 6 years ago

shadowwider commented 6 years ago

Hi. I saw function like make_holidays in your code. And in readme you also said holiday is a import feature.But it seems you drop to use the holiday with country.Why?

Arturus commented 6 years ago

Week seasonality is important feature, holidays is not (tried it, no improvements to score). May be my source of holidays information per country was imprecise, you can try different source.