fixed the card responsiveness for tablet view in home page

swastik-bose007 commented 2 years ago

Related Issue

Issue No. #105

Changes you made :

There was conflict between bootstrap default margin and custom margin so i removed bootstrap classes and make it simple using only custom CSS property.

Describe the changes :

I have observed the code structure and its rendering in webpage and I came to a conclusion that the additional margin used over bootstrap layout was causing the responsiveness issue so I have fixed the margin issue by removing row col bootstrap classes and made it simple with raw CSS property maintaining the margins. ##Apart from this i have added a box shadow in the cards which make better UI in this light tone website

This action solved the responsiveness issue in middle width devices (Tablets)

Check list :

[x] I have followed code style of this project.
[x] I have read the CONTRIBUTING document.
[x] All the aspects mentioned in the issue are covered.
[x] The website is properly working after my changes.
[x] 🌟 ed the repo

Type of change :

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Output Screenshots :

Arun9739 commented 2 years ago

Good @swastik-bose007 But plz resolve branch conflicts for merging

swastik-bose007 commented 2 years ago

It's resolved please check it now

On Fri, 7 Oct, 2022, 7:11 pm Arun G Nayak, @.***> wrote:

Good @swastik-bose007 https://github.com/swastik-bose007 But plz resolve branch conflicts for merging

— Reply to this email directly, view it on GitHub https://github.com/Arun9739/Paryatana/pull/132#issuecomment-1271610237, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXOJHT6OYIYV54TC5WAMOATWCASADANCNFSM6AAAAAAQ64Z4WE . You are receiving this because you were mentioned.Message ID: @.***>

Arun9739 commented 2 years ago

@swastik-bose007 Sorry for inconvenience But again there have been conflicts. Plz resolve.

swastik-bose007 commented 2 years ago

Give me just 10 minutes I am working immediately

On Sat, 8 Oct, 2022, 6:13 pm Arun G Nayak, @.***> wrote:

@swastik-bose007 https://github.com/swastik-bose007 Sorry for inconvenience But again there have been conflicts. Plz resolve.

— Reply to this email directly, view it on GitHub https://github.com/Arun9739/Paryatana/pull/132#issuecomment-1272310895, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXOJHT2AFGPGIT3XZLCQEZLWCFT7NANCNFSM6AAAAAAQ64Z4WE . You are receiving this because you were mentioned.Message ID: @.***>

swastik-bose007 commented 2 years ago

Done

On Sat, 8 Oct, 2022, 6:13 pm Arun G Nayak, @.***> wrote:

@swastik-bose007 https://github.com/swastik-bose007 Sorry for inconvenience But again there have been conflicts. Plz resolve.

— Reply to this email directly, view it on GitHub https://github.com/Arun9739/Paryatana/pull/132#issuecomment-1272310895, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXOJHT2AFGPGIT3XZLCQEZLWCFT7NANCNFSM6AAAAAAQ64Z4WE . You are receiving this because you were mentioned.Message ID: @.***>

Arun9739 commented 2 years ago

Good to Go @swastik-bose007 LGTM 👍

Arun9739 commented 2 years ago

@swastik-bose007 Your changes created some problems Bcz you haven't properly handled latest commits made by other people. Next time create proper changes. You can work on this again if you wish.

Arun9739 / Paryatana