search

Arun9739 / Paryatana

A front-end website for travel agency.
https://arun9739.github.io/Paryatana/
MIT License
137 stars 131 forks source link

Changed the footer on all pages to stay constant. #320

Closed RXBlade closed 2 years ago

RXBlade commented 2 years ago

@Arun9739 Looks like #318 is already done. Fixed the buggy resolution on the logo as well

RXBlade commented 2 years ago

@Arun9739 will you check my PR?

Arun9739 commented 2 years ago

@RXBlade Plz upload the screenshot of section where you have changed.

RXBlade commented 2 years ago

Here are some screenshots, it's the exact same footer on all pages, the consistency was so bad before.

Screenshot 2022-10-26 091027 Screenshot 2022-10-26 091053 Screenshot 2022-10-26 091106

Arun9739 commented 2 years ago

@RXBlade Plz add issue number, description of changes, checklist(which was there in original PR format). Follow the contributing guidelines.

RXBlade commented 2 years ago

Another one that only cares about useless templates... The issue was solved and I don't have the time or interest to write a documentation for this joke of a static, useless website.

Make someone else write your things.

Arun9739 commented 2 years ago

@RXBlade It may be a joke website for joker people. But it has got some reputation in hacktoberfest. First learn to behave properly and give respect to small things also. As mentioned in contributing guidelines you have not created a separate branch nor given description.

The documentation gives proper description of your work. It looks like you dont know to write the description. Plz learn it. We force you to create issues, so as to make you work in proper direction.

If you have contributed to this useless website means you have did for getting swags. Do the contribution for learning purpose. Last thing, the template may look useless to useless people.

RXBlade commented 2 years ago

I have given this project the respect it deserves, you have 0 guidelines for the actual code that goes into this project since it's consistency is a 0 just like, oh well.. it's owner. I didn't insult you in the last comment, but since you dare insult me for lols.. I don't mind telling you that you have no idea what coding is, god forbid if you actually manage to get a leading job.. as you all prefer. Nevertheless, you should stick professionally to more casual topics like scamming people.

Arun9739 commented 2 years ago

@RXBlade You actually didn't deserve anything other than insulting people. First learn to accept your mistake and work upon improving it.