search

Arvtesh / UnityFx.Outline

Screen-space outlines for Unity3d.
MIT License
1.28k stars 90 forks source link

Built-in package warns even if URP version is installed. #37

Closed connffuused closed 3 years ago

connffuused commented 3 years ago

This is not a big deal but I prefer to remove unnecessary warning for some inhouse rules. Is it intended to print warning when URP installed? If not, I'll PR related to this issue.

Thanks.

UnityEngine.Debug:LogWarningFormat (UnityEngine.Object,string,object[])
UnityFx.Outline.OutlineResources:LogSrpNotSupported (UnityEngine.Object) (at Library/PackageCache/com.unityfx.outline@0.8.4/Runtime/Scripts/OutlineResources.cs:497)
UnityFx.Outline.OutlineEffect:Awake () (at Library/PackageCache/com.unityfx.outline@0.8.4/Runtime/Scripts/OutlineEffect.cs:159)

image

Arvtesh commented 3 years ago

Both OutlineEffect and OutlineBehaviour are not designed to work with URP. This is what the warning says. Works as intended as far as I can see.

connffuused commented 3 years ago

Oh, I see. Thanks.