search

Arvtesh / UnityFx.Outline

Screen-space outlines for Unity3d.
MIT License
1.28k stars 90 forks source link

Missing Profiler.EndSample (BeginSample and EndSample count must match): OutlinePass #44

Closed Delt06 closed 3 years ago

Delt06 commented 3 years ago

How to reproduce:

The console becomes filled with these error messages: image

Missing Profiler.EndSample (BeginSample and EndSample count must match): OutlinePass
Previous 5 samples:
    RenderTexture.SetActive
    OutlinePass
    Outline-256
    JobAlloc.Grow
    RenderLoop.CleanupNodeQueue
In the scope:
    OutlinePass
    Outline-256
    Render Camera
    UnityEngine.CoreModule.dll!UnityEngine.Rendering::RenderPipelineManager.DoRenderLoop_Internal() [Invoke]
[Invoke]
    PlayerLoop
Non matching Profiler.EndSample (BeginSample and EndSample count must match): OutlinePass
Previous 5 samples:
    Graphics.DrawProcedural
    RenderTexture.SetActive
    Graphics.DrawProcedural
    RenderTexture.SetActive
    Outline-256
In the scope:
    Outline-256
    Render Camera
    UnityEngine.CoreModule.dll!UnityEngine.Rendering::RenderPipelineManager.DoRenderLoop_Internal() [Invoke]
[Invoke]
    PlayerLoop
    Main Thread

Was able to reproduce in the Outline.URP project with 2019.4.17f1 and in a project that imports the package from npm with 2020.3.0f1.

Delt06 commented 3 years ago

Found this: https://issuetracker.unity3d.com/issues/urp-unreleased-version-profiler-spams-errors-when-enabled-in-playmode Looks like a bug from URP. Not sure whether something can be done aside from removing the ProfilerScope from OutlinePass.

Arvtesh commented 3 years ago

Yes, I've spent some time on investigation and it seems to be an URP issue. At least I wasn't able to fix it on my side.

Noxalus commented 3 years ago

I have the same issue using these packages version:

"com.unityfx.outline": "0.8.4",
"com.unityfx.outline.urp": "0.4.0",

But the issue doesn't exist if I go back to the version 0.3.0 of the com.unityfx.outline.urp package. So that's what I did!

TheXRMonk commented 3 years ago

I have the same issue using these packages version:

"com.unityfx.outline": "0.8.4",
"com.unityfx.outline.urp": "0.4.0",

But the issue doesn't exist if I go back to the version 0.3.0 of the com.unityfx.outline.urp package. So that's what I did!

Same issue and same solution here as well.

Arvtesh commented 3 years ago

Should be fixed in v0.8.5.

james-arndt commented 1 year ago

Should be fixed in v0.8.5.

Not fixed in latest. Issue is appearing on Mac platform, but not on Windows.