search

Arvtesh / UnityFx.Outline

Screen-space outlines for Unity3d.
MIT License
1.27k stars 90 forks source link

Problems with Metal on 2022.2.1f1 #65

Open dev-fredericfox opened 1 year ago

dev-fredericfox commented 1 year ago

Used to work flawlessly on iOS but getting this Error when upgrading my project to Unity 2022.2.1f1:

(after updating the package to PR #62)

Shader error in 'Hidden/UnityFx/OutlineColor.URP': invalid subscript 'uv' at line 26 (on metal)

Compiling Subshader: 0, Pass: Opaque, Vertex program with <no keywords>
Platform defines: SHADER_API_MOBILE UNITY_ASTC_NORMALMAP_ENCODING UNITY_ENABLE_REFLECTION_BUFFERS UNITY_LIGHTMAP_RGBM_ENCODING UNITY_NO_RGBM UNITY_NO_SCREENSPACE_SHADOWS UNITY_PBS_USE_BRDF2
Disabled keywords: INSTANCING_ON SHADER_API_GLES30 UNITY_COLORSPACE_GAMMA UNITY_ENABLE_DETAIL_NORMALMAP UNITY_FRAMEBUFFER_FETCH_AVAILABLE UNITY_HALF_PRECISION_FRAGMENT_SHADER_REGISTERS UNITY_HARDWARE_TIER1 UNITY_HARDWARE_TIER2 UNITY_HARDWARE_TIER3 UNITY_LIGHTMAP_DLDR_ENCODING UNITY_LIGHTMAP_FULL_HDR UNITY_LIGHT_PROBE_PROXY_VOLUME UNITY_METAL_SHADOWS_USE_POINT_FILTERING UNITY_NO_DXT5nm UNITY_NO_FULL_STANDARD_SHADER UNITY_PBS_USE_BRDF1 UNITY_PBS_USE_BRDF3 UNITY_PRETRANSFORM_TO_DISPLAY_ORIENTATION UNITY_SPECCUBE_BLENDING UNITY_SPECCUBE_BOX_PROJECTION UNITY_UNIFIED_SHADER_PRECISION_MODEL UNITY_USE_DITHER_MASK_FOR_ALPHABLENDED_SHADOWS UNITY_VIRTUAL_TEXTURING
CaseyHofland commented 1 year ago

See #63 for fixing this. You can safely delete the OutlineColor.URP shader and instead use Unity's default Unlit Shader in its place (inside the OutlineResources.URP asset)

james-arndt commented 1 year ago

@CaseyHofland Our team is experiencing an issue where the iOS build does not show the outline. On our Windows and Mac desktop builds the outlines display beautifully. In the Editor on Mac and Windows the outline also shows. Still trying to dig into why it isn't showing on the iPad and iOS. There are no obvious compile errors in the logs or in the console.