search

ArxOne / FTP

Simple FTP client
MIT License
37 stars 15 forks source link

symbolic link to directory maybe unrecognizable #14

Closed Onway closed 8 years ago

Onway commented 8 years ago

I run the unit tests in TestCategory with IIS Ftp Server, all passed except FileExistsTest, because there is no key word "FtpEntryType.Link" in WindowsFtpPlatform.ParseLine method. In fact, the response lines by STAT command have no symlink identifier. image

By vsftpd in linux, FileExistsTest passed if symlink to file, but failed to directory, because the response line by FtpClient.GetEntry for a folder is always start with 'd', even if the foder is symlink. So the last Assert statement in FileExistsTest failed. image

picrap commented 8 years ago

Thanks! I really need to refine my tests :persevere: Do you wanna help? :wink:

Onway commented 8 years ago

I dont' know much about the code, but if I can help, I will be glad:grinning:

picrap commented 8 years ago

I'm going to open a ticket to refactor tests. --> https://github.com/ArxOne/FTP/issues/18

picrap commented 8 years ago

The ticket will stay closed, but this is just to note here that there is no way to detect symlinks with IIS.