search

ArxOne / FTP

Simple FTP client
MIT License
37 stars 15 forks source link

Characters " []()" seem don't need to be escaped #15

Closed Onway closed 8 years ago

Onway commented 8 years ago

Without escaping, ParenthesisNameTest, BracketsNameTest and SpaceNameTest also work well. And that if escaping, these tests will fail by Fillzilla on Windows and vsftpd in LIST command, and when exception throw, the test code will be blocking by filezilla but vsftpd won't.

Besides, above three tests also fail since Fillzilla Server on Windows unsupported STAT command.

picrap commented 8 years ago

The tests fail on pure-ftpd without escaping, and it's the ftp server I'm using :smile: Regarding FileZilla and STAT support, I am sorry about that, but there too, I'm using pure-ftpd and it supports this command. In a more pragmatic way, what are your suggestions? Changing tests? Let me know if you have ideas, since they're always welcome.

Onway commented 8 years ago

I test with pure-ftpd v1.0.36 on CentOS 7, here is the result: image It seems only the "space" character is controversial. But in any case, in my opinion, escape or not should be determined by user. What do you think about this problem?

picrap commented 8 years ago

Currently I added a FtpPlatform which can be provided as a parameter to the FtpClient (via FtpParameters). You can provide your own implementation, in order to avoid any escaping. Regarding the brackets and parenthesis, that's right, I made a blind fix for someone who had the problem (and the fix workd). Since it also works with other ftp servers, I keep the escaping, even if it is not always necessary. So, I you don't have an objection, I'm going to close this issue. Is it OK for you?

Onway commented 8 years ago

Yes, I have saw the constructor of FtpClient, it's OK to close this issue.

picrap commented 8 years ago

:+1: