struct with properties or methods skips logic

FrankLakmann commented 5 years ago

Hi,

after dorian reported one issue with structs (https://github.com/ArxOne/MrAdvice/issues/108) we found another one: Structs with auto properties or methods seem to just skip the logic when a MethodAdvice aspect is applied.

    public struct TestStruct
    {
        public int N { get; set; }
    }
    public class Program
    {
        static void Main(string[] args)
        {
            var t = new TestStruct();
            t.N = 12;
            var x = t.N;
            Console.WriteLine("Is the value actually readable from the autoprop of the struct?: " + x);
        }
    }

results in x=0.

This is the code after weaving according to ILSpy:

// TestStruct
using ArxOne.MrAdvice;
using ArxOne.MrAdvice.Annotation;
using StructIssueDemo;
using System;
using System.Runtime.CompilerServices;

public struct TestStruct
{
    public int N
    {
        [CompilerGenerated]
        get
        {
            return (int)⚡Invocation.ProceedAspect(this, (RuntimeMethodHandle)/*OpCode not supported: LdMemberToken*/, (RuntimeMethodHandle)/*OpCode not supported: LdMemberToken*/, (RuntimeMethodHandle)/*OpCode not supported: LdMemberToken*/);
        }
        [CompilerGenerated]
        set
        {
            ⚡Invocation.ProceedAspect(this, new object[1]
            {
                value
            }, (RuntimeMethodHandle)/*OpCode not supported: LdMemberToken*/, (RuntimeMethodHandle)/*OpCode not supported: LdMemberToken*/, (RuntimeMethodHandle)/*OpCode not supported: LdMemberToken*/);
        }
    }

    [ExecutionPoint]
    private int N.get′()
    {
        return N;
    }

    private static object get_N″(object P_0, object[] P_1)
    {
        return ((TestStruct)P_0).N.get′();
    }

    [ExecutionPoint]
    private void N.set′(int value)
    {
        N = value;
    }

    private static object set_N″(object P_0, object[] P_1)
    {
        ((TestStruct)P_0).N.set′((int)P_1[0]);
        return null;
    }
}

Here is a demo example: https://github.com/FrankLakmann/MrAdviceTest Sorry I wasn't able to put it in one cs file because of StackOverflowExceptions. Thank you