Aryainguz / Euphoria-Check-PERMA-Meter-Express

🌟 EuphoriaCheck - A Modern PERMA Meter. This web application, built using Express and Node.js, measures your happiness and life satisfaction based on the PERMA model of well-being by psychologist Dr Martin Seligman.
https://euphoria-check-perma-meter-express.vercel.app/
MIT License
19 stars 19 forks source link

Bug : Standardize Promise Handling #15

Closed mathanraj0601 closed 11 months ago

mathanraj0601 commented 11 months ago

standardize Promise Handling

await sgMail
      .send(message)
      .then((response) => console.log("Email sent!"))
      .catch((error) => console.log(error.message))

    res.render("result", { pos: p, eng: e, mea: m, rel: r, acc: a 

In our codebase, there is a mix of using await and then/catch for handling promises. We need to standardize the approach to improve code consistency and maintainability.

Plan:

mathanraj0601 commented 11 months ago

I am excited to work on this @Aryainguz Can you assign me this for SWOC24?

Aryainguz commented 11 months ago

Great observation and thought @mathanraj0601 go ahead and feel free to reach out for any help!

mathanraj0601 commented 11 months ago

That's great @Aryainguz

mathanraj0601 commented 11 months ago

Hey @Aryainguz 🌟 I've submitted a PR for the task mentioned . While diving into the issue, I spotted some opportunities to enhance the code for better readability and error handling. So, I've create another issue or those improvements.

Could you kindly assign me to the linked issue (#29 ) ? I'm eager to kickstart the work and contribute to the project!