Aryamanz29 / Elastic-CFC

A Logs analyzer for developers builds on top of elastic search. 📜⚡
https://github.com/Aryamanz29/Elastic-CFC
14 stars 9 forks source link

Feature/user #29

Closed Ashsenior closed 2 years ago

Ashsenior commented 2 years ago

Related Issues or bug

Fixes: #27

Proposed Changes

Additional Info

Screenshots

Original Updated
original screenshot updated screenshot

Screenshot (66) Screenshot (67) ![Screenshot (68)](https://user-images.githubusercontent.c Screenshot (69) om/49332381/158767284-1bc22b88-53b9-41cb-9820-38a949b7ff6a.png)

Ashsenior commented 2 years ago

Thnx for the appreciation

I guess it's an error caused because i didn't add csrf_token . Try now

And it is working totally fine in my desktop .

Ashsenior commented 2 years ago

Any problem ?? @Aryamanz29

Ashsenior commented 2 years ago

Hey @Aryamanz29 how do I solve the code formatting issue ?

HemantSachdeva commented 2 years ago

Hey @Aryamanz29 how do I solve the code formatting issue ?

Download flake8 python library using pip and format the code, commit and push it.

HemantSachdeva commented 2 years ago

@Aryamanz29 Why do we have black and flake both checks? :thinking:

Ashsenior commented 2 years ago

@Aryamanz29 Why do we have black and flake both checks? 🤔

Do i remove the black-check code ?

HemantSachdeva commented 2 years ago

@Aryamanz29 Why do we have black and flake both checks? thinking

Do i remove the black-check code ?

Amm your choice, it just focus on single/double quotes and formats a dictionary in a single line (awful imo). That's all what I've observed about the black linting.

Ashsenior commented 2 years ago

can you please merge it now ? and please add the level3 and GSSoC22 tag because gssoc system doesnt recognizes it otherwise @Aryamanz29

Aryamanz29 commented 2 years ago

can you please merge it now ? and please add the level3 and GSSoC22 tag because gssoc system doesnt recognizes it otherwise @Aryamanz29

I'm really sorry. I'm too busy with my other commitments. Last time I've reviewed your PR's it looks good to me, but I guess when running a search on logs after uploading it doesn't show me expected results. I'll test it again and let you know :+1: Right now, I'm merging your work to develop branch and also added appropriate issue labels to so that it will count towards your contribution :+1:

Aryamanz29 commented 2 years ago

@Aryamanz29 Why do we have black and flake both checks? thinking

We're using Flake8 for ensuring code follows PEP 8 standard & Black for code formatting.

Aryamanz29 commented 2 years ago

@Ashsenior Thanks for your contribution 🎉 & @HemantSachdeva For helping him out :+1: