Aryan20 / Logomenu

Quick access menu for the GNOME panel with options that help ease the workflow for newcomers and power users alike.
https://extensions.gnome.org/extension/4451/logo-menu/
GNU General Public License v2.0
51 stars 31 forks source link

Custom command for extension application #40

Closed RobOT05442309 closed 1 year ago

RobOT05442309 commented 1 year ago

Hello,

I would like to request for a feature if possible.

When clicking on "Extensions" into the menu, it bring back the default's gnome manager, I was wondering if there will be a way to add a custom command just like gnome-terminal and gnome-software.

# Custom command could be:
flatpak run com.mattjakeman.ExtensionManager

Edit: Update command since I make a double flatpak run command...

For the background story:

I'm using the flatpak application "Extension manager" (https://flathub.org/apps/details/com.mattjakeman.ExtensionManager) to handle gnome shell extensions and installation instead of default gnome's one (easier to install extensions when using flatpak browser that does not currently support chrome's gnome shell extension).

There is no rush about it, I just wanted to know if you could make it or not at all.

Anyway, thanks you for your work and time on this extension!

Aryan20 commented 1 year ago

Hey, Thanks for using my extension and for your kind remarks! I have already added support for the application you shared, the extension checks if you have the default GNOME Extensions application installed or not, if not then it searches for the "Extension manager" application and launches that if installed. It could be that you have both applications installed simultaneously. Can you check if it works with the default one removed? :)

RobOT05442309 commented 1 year ago

Thanks for your quick feedback!

Well, you're right, I have both of them (I keep the original one hidden from application grid 'just in case' something goes wrong with the flatpak, not maintained anymore or otherwise and/or since I don't know how extensions updates are handles from any of this applications), so I have uninstall the gnome-extensions-app, reload the shell but sadly now nothing happened when I click on Extensions in the submenu, I'll do a reboot to check if it's working after and edit this post to give you a feedback!

Edit: Still not working after reboot

Even if it worked, do you think that this feature request could still be implemented or it will be too much work from your side combining the custom command and the check of available application on the system?

Edit: Also I just find that even if I check the "Disable lock screen" option in the settings of the extension it just stay in the menu no matter what I do, do you want me to debug something and/or open a new issue for this?

Edit 2: After forcing toogle off into dconf the option show-lockscreen, it disappear from the menu list this is due to a wrong translation in French (not a big deal), this is the correct sentence in the fr.po file (basically in French it currently say 'Hide' instead of 'Show'):

Line 112 to 114:
#: PrefsLib/adw.js:221 PrefsLib/gtk.js:341
msgid "Show Lock Screen option"
msgstr "Cacher l’option « Verrouiller l’écran »"

Correct string:

Line 112 to 114:
#: PrefsLib/adw.js:221 PrefsLib/gtk.js:341
msgid "Show Lock Screen option"
msgstr "Afficher l’option « Verrouiller l’écran »"
Aryan20 commented 1 year ago

Hey, thanks for all your input! It is weird, it should have worked, as it did when I tried it on a virtual machine. But no issues, I will add a toggle to switch between the default one and the "Extension Manager". Regarding the french translation, thanks for pointing it out, will be updating it soon :)

Aryan20 commented 1 year ago

I have added the option to change the Extension app. You can try it out by either downloading the code from here and installing it or you can wait for the next version release, whenever that happens :)

RobOT05442309 commented 1 year ago

Thanks you for the quick fix, I'll test it when a new release will update and report here (even if the issue is close).

I don't know on what system you've try it on VM but I use Fedora 36 if that can help for anything.

Additionally I've made the French translation for the new added strings if you want to add them at some point:

# From line 100 to 110

#: PrefsLib/adw.js:152 PrefsLib/gtk.js:186
msgid "Preferred Extensions Application"
msgstr "Application d'extension préférée"

#: PrefsLib/adw.js:158 PrefsLib/gtk.js:193
msgid "GNOME Extensions"
msgstr "Extensions de GNOME"

#: PrefsLib/adw.js:159 PrefsLib/gtk.js:194
msgid "Extensions Manager"
msgstr "Gestionnaire d'extensions"

Have a nice day!

Aryan20 commented 1 year ago

Hey, thanks for your work!

I will definitely be adding your changes to the translation.

Have a great day too! :D