AryanNanda17 / NonStop-Lofi-Vibe-Generator

MIT License
38 stars 22 forks source link

Add Link to logo #55

Closed AryanNanda17 closed 1 month ago

AryanNanda17 commented 1 month ago

On the homepage, add a link to the logo so that whenever someone clicks on it, the page refreshes and they return to the same homepage.

Screenshot 2024-10-03 at 7 55 55 AM

It can simply be done using <a href="/">logo.img</a>

fudgemasterultra commented 1 month ago

@AryanNanda17 Looks like a good first issue, and I'll need to get the environment setup. Mind if I take this one?

AryanNanda17 commented 1 month ago

Hello @fudgemasterultra, Go ahead with it!

AryanNanda17 commented 1 month ago

@fudgemasterultra, also, it would be really great and motivating for our team if you could star this repo so that this project reaches more people. Thanks again for your interest. I am assigning this to you

fudgemasterultra commented 1 month ago

@AryanNanda17 Do you want it to refresh the page on clicking or redirect the user back to the / route? Right now it looks like we use the Link element and have that guide the user to the / route, and the reason it isn't refreshing the page is because of the way the Link property works. We can change it to an anchor element, but there is a bit of a jarring white screen then back to the app.

Also I have stared the app. :)

ParamThakkar123 commented 1 month ago

@fudgemasterultra we want it to redirect the user back to / route on clicking the logo

fudgemasterultra commented 1 month ago

@ParamThakkar123 This has been fixed in PR#56

ParamThakkar123 commented 1 month ago

Okay, @AryanNanda17 just take a look. Things are working as expected so maybe we can merge this after you approve these changes.