search

AryanNanda17 / NonStop-Lofi-Vibe-Generator

MIT License
38 stars 22 forks source link

Added About Page with proposed changes and Button on Navbar #59

Closed shubhrad1 closed 1 month ago

shubhrad1 commented 1 month ago

Closes #51

Made the proposed changes to About Page and added a button on the Navbar to navigate to About Page.

Due to a merge conflict, the previous PR was closed so I am creating a new PR with up to date changes.

AryanNanda17 commented 1 month ago
Screenshot 2024-10-04 at 1 35 12 AM Screenshot 2024-10-04 at 1 35 21 AM
AryanNanda17 commented 1 month ago

LGTM!! Great work @shubhrad1

shubhrad1 commented 1 month ago

Thanks @AryanNanda17

ParamThakkar123 commented 1 month ago

@shubhrad1 This looks great to me for now. There are further UI enhancements (because the information is just written down here) and ton of information is not exciting. We would want to make the UI of this page more better and immersive but I think that can be covered in another issue.

ParamThakkar123 commented 1 month ago

This is ready to be merged

ParamThakkar123 commented 1 month ago

Thanks for your contribution @shubhrad1 !