AryanNanda17 / NonStop-Lofi-Vibe-Generator

MIT License
38 stars 22 forks source link

FrontPage UI Improved #75

Closed anuj846k closed 1 month ago

anuj846k commented 1 month ago

Fixes #70 Changes Made

  1. I have created a Card grid view and added some shadows and better readability of text and it is responsive for mobiles also [Image of 1 changes made] image

  2. Replace text based play and pause in the navbar with play and pause react icon and shifted it to bottom right [Image of 2 changes made] image image

AryanNanda17 commented 1 month ago
Screenshot 2024-10-16 at 9 32 21 PM

What is learn more here? It is useless.

Screenshot 2024-10-16 at 9 32 43 PM

Why did you add these buttons?

AryanNanda17 commented 1 month ago

The button looks good to me. You can remove the "click to play" text and just display the play button. Additionally, the play button should be activated by pressing the space key as well.

anuj846k commented 1 month ago

image

ParamThakkar123 commented 1 month ago

@anuj846k any updates ??

anuj846k commented 1 month ago

@anuj846k any updates ??

I have already updated the pull request 1 day ago commit id 281f9220182e7e3ae3b865a0747efb5c6e55e4d5

ParamThakkar123 commented 1 month ago

@anuj846k any updates ??

I have already updated the pull request 1 day ago commit id 281f922

Okay, great. I am updating the codebase to add CI workflow for auto deployment

ParamThakkar123 commented 1 month ago

Visual Element: Incorporate a small 3D object to enhance the visual appeal.

@anuj846k this part is yet to be done right ??

anuj846k commented 1 month ago

Visual Element: Incorporate a small 3D object to enhance the visual appeal.

@anuj846k this part is yet to be done right ??

I tried but didn't find anything interesting also i have not worked with three js yet