AryanNanda17 / NonStop-Lofi-Vibe-Generator

MIT License
38 stars 23 forks source link

Update Readme's tech stack section #82

Closed AryanNanda17 closed 1 month ago

AryanNanda17 commented 1 month ago
Screenshot 2024-10-20 at 9 36 58 PM

Change the above one to the below one but instead of technologies names put their logos.

Screenshot 2024-10-20 at 9 38 28 PM
wolfofdalalst commented 1 month ago

Can you please assign me this issue?

AryanNanda17 commented 1 month ago

Sure @wolfofdalalst

wolfofdalalst commented 1 month ago

@AryanNanda17 pr #83 has been created, kindly review.

AryanNanda17 commented 1 month ago

@wolfofdalalst, you closed the pr... you still working or not?

wolfofdalalst commented 1 month ago

Yes i am working on this pr, i will create a new pr within a few minutes.

AryanNanda17 commented 1 month ago

@wolfofdalalst, I have reverted the changes you made. There are many different frameworks which we have used but you have only mentioned few of them. Please do another pr which adds all the frameworks we have used in req format

wolfofdalalst commented 1 month ago

@AryanNanda17 Please clarify whether you just wanted the technologies used in a tabular format without any additions or deletions, or the list had to be updated with the ones mentioned in the screenshot of the table you provided. According to your issue, I had to replace the names of the technology with their respective badge/icon, which was done.

AryanNanda17 commented 1 month ago

@wolfofdalalst Exactly, you have to replace the name with the badge and represent it in tabular format. And what did you do in your PR? You removed the names of many existing technologies we are using, like Three.js, and WebGL. If you are doing a pr make sure to not remove anything which is already there.

wolfofdalalst commented 1 month ago

Ok I will create a pr within a few minutes.

AryanNanda17 commented 1 month ago

Issue Resolved... so closing this one