Adding support with multiple volume with the same name on different Vserver

MicKBfr commented 3 months ago

Bug description

when we have for exemple test volume on different vserver Exemple : SVM1 : test SVM: test

we have some issue with Get-Ncvol -volume test without vserver context

COMMENTAIRES : [ 12:24:33:080 ] [ Document ] - Collecting ONTAP Vserver volumes snapshot information. AVERTISSEMENT : [ 12:24:33:961 ] [ Document ] - Impossible de traiter la transformation d'argument sur le paramètre « TEXT ». Impossible de convertir la valeur en type System.String.

Get-NcEfficiency : La référence d'objet n'est pas définie à une instance d'un objet. Au caractère C:\Users\toto\Documents\WindowsPowerShell\Modules\AsBuiltReport.NetApp.ONTAP\0.6.7\Src\Public\Invoke-AsBuiltReport.NetApp.ONTAP.ps1:645 : 37

... if (Get-NcEfficiency -Volume $VolFilter.Name -Controller $Arr ...


+ CategoryInfo          : InvalidOperation : (:NcController) [Get-NcEfficiency], NullReferenceException
+ FullyQualifiedErrorId : ApiException,DataONTAP.C.PowerShell.SDK.Cmdlets.Toolkit.Efficiency.GetNcEfficiency

Command-line input

New-AsBuiltReport -Report 'NetApp.ONTAP' -Target $NetApp -credential $Credential -Format 'Word','HTML' -AsBuiltConfigFilePath $varCheminRepertoireScript'\Config\config.json' -ReportConfigFilePath $varCheminRepertoireScript'\Config\AsBuiltReport.NetApp.ONTAP.json' -OutputFolderPath $varCheminRepertoireScript'\Output' -Filename $NetApp -EnableHealthCheck -Timestamp -verbose -Debug

Steps to reproduce

create some volume with same name on different SVM
generate report

Expected behaviour

No Warning

Screenshots

No response

Operating System

Windows

PowerShell Version

Name Value

PSVersion 5.1.17763.5830
PSEdition Desktop
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0...}
BuildVersion 10.0.17763.5830
CLRVersion 4.0.30319.42000
WSManStackVersion 3.0
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1

PowerShell Modules

Name Version

AsBuiltReport.NetApp.ONTAP 0.6.7
PScribo 0.10.0

Additional Context

Fix will be available in few days

Before submitting

[X] I have read and followed the bug reporting guidelines.
[X] I have read the documentation, and referred to the known issues before submitting this bug report.
[X] I have checked for previously opened & closed issues before submitting this bug report.

MicKBfr commented 3 months ago

Try to fix it. Let me know if it's OK

Thanks

rebelinux commented 3 months ago

Good catch. The code looks good to me. Thank you!

AsBuiltReport / AsBuiltReport.NetApp.ONTAP