AsBuiltReport / AsBuiltReport.PureStorage.FlashArray

MIT License
9 stars 5 forks source link

Update to Asbuilt report to run on pure storage SDK2 #17

Closed jhall12 closed 10 months ago

jhall12 commented 11 months ago

Description

This change is to uplift the code used in the AsBuiltReport.PureStorage.FlashArray to work with Pure's new SDK2 Module leveraging their new API

Related Issue

https://github.com/AsBuiltReport/AsBuiltReport.PureStorage.FlashArray/issues/16

Motivation and Context

Change was required due to the forced obsolescence of the SDK1 commands in purity OS 6.4.X It was also found that running the existing version on purity OS 6.3.X showed more and more errors over time

How Has This Been Tested?

Test detail Script has been tested on Purity OS 6.4.10, 6.3.7, 6.3.10, 6.3.12 with and without //file enabled with no issues. Each change to the existing script was done by walking down the entire Array and updating the command to SDK2 and then subsequently updating the section associated with the updated array command. After these updates where completed the script was run to ensure formatting and information matched an existing script's output. Due to the changes in SDK2 from SDK1 a lot of rework was required due to the movement of functionality in the API All aspects of the Script has been tested due to the entire script being re-factored to support SDK2

Testing Environment multiple Pure sans and differing levels of code from 6.3.7 up to 6.4.10 Script was tested on lower environments first to gauge functionality then ran against differing versions of the purity OS in a production environment.

Change Effects As this was a complete re-write to allow SDK2 functionality it has dramatically changed the entire code base

Screenshots (if appropriate):

Types of changes

Checklist:

rebelinux commented 11 months ago

An amazing work! 👏

rebelinux commented 10 months ago

Any chance of getting this code merged?

I have access to a Pure environment and would like to test this also have some friends who can contribute to this report!