search

AsYetUntitled / Framework

Altis Life RPG mission framework for Arma 3 originally made by @TAWTonic.
Other
245 stars 308 forks source link

BattlEye filters for DEV 5.0 are pretty fucked up!!? #214

Closed Angrygargamel closed 7 years ago

Angrygargamel commented 7 years ago

i just saw the be filters for the dev version for example 5 createDialog !\"altisPhone\" !\"Chop_Shop\" !\"DeathScreen\" !\"Federal_Safe\"

all these \" on beginning and end of an exception are wrong... (afaik - correct me if im wrong) an exception has always to start and end with " without any \

5 createDialog !"altisPhone" !"Chop_Shop" !"DeathScreen" !"Federal_Safe"

and there are many more...

Jawshy commented 7 years ago

@Angrygargamel, the exceptions you listed for createDialog in scripts.txt are fine.

Also, when reporting a bug or other issue please follow the issue template that is provided.

Jawshy commented 7 years ago

\ is an escape character.

Angrygargamel commented 7 years ago

which shouldnt be on the opening " and the closing " or am i wrong?

Jawshy commented 7 years ago

They should be and they are.

Angrygargamel commented 7 years ago

since when should they be also on the opening and closing " because it was damn wrong before... !"exception" was right !\"exception\" was wrong it should be used for " inside the exception like !"exception \"blabla\"" afaik the first and last " should never be "escaped" as they have a function

Jawshy commented 7 years ago

See BattlEye Filters.

Are these filters causing false positives or false negatives, or are they only wrong in theory?

Angrygargamel commented 7 years ago

well if the wiki is right (and me too) then the filters are wrong there is no escape \ on leading/ending quotation marks only within so if its with escaping backslash before now even on leading and ending quotationmarks then the wiki is wrong (and me too)

Jawshy commented 7 years ago

Framework/Altis_Life.Altis/core/shops/fn_chopShopMenu.sqf, line 21: 

if (!(createDialog "Chop_Shop")) exitWith {hint localize "STR_Shop_ChopShopError"};

Framework/BEFilters/scripts.txt, line 4: 

5 createDialog !\"altisPhone\" !\"Chop_Shop\" !\"DeathScreen\" !\"Federal_Safe\" !\"Life_Admin_Compensate\" !\"life_admin_menu\" !\"Life_atm_management\" !\"Life_cell_phone\" !\"Life_Clothing\" !\"Life_Create_Gang_Diag\" !\"Life_FuelStat\" !\"Life_impound_menu\" !\"Life_key_management\" !\"Life_My_Gang_Diag\" !\"life_news_broadcast\" !\"life_spawn_selection\" !\"life_ticket_give\" !\"life_ticket_pay\" !\"Life_Vehicle_Shop_v2\" !\"life_wanted_menu\" !\"life_weapon_shop\" !\"pInteraction_Menu\" !\"playerSettings\" !\"RscDisplayCamera\" !\"RscDisplayDebugPublic\" !\"RscDisplayWelcome\" !\"RscGUIEditor\" !\"SettingsMenu\" !\"shops_menu\" !\"TrunkMenu\" !\"vInteraction_Menu\"

The exception - !\"Chop_Shop\" - is for "Chop_Shop". This is to say that the " (quotation marks) are a part of the exception which is intended and is correct. The following would also work as exceptions: !"Chop_Shop" and !Chop_Shop.

Angrygargamel commented 7 years ago

alright... i have read the wiki again and your posts again.... i guess now i get it... i was just confused because i have never seen filters done this way before

so this issue can be closed i guess