search

Asad-acc / Design-System

0 stars 0 forks source link

Create checkbox component #1

Open Asad-acc opened 1 year ago

Tosin-Balogun commented 1 year ago

On mobile, the bottom padding for the fieldset is 16px rather than 24px

Tosin-Balogun commented 1 year ago

Is there a reason why 350px width is used for mobile and 750px for desktop?

According the data I got from the analytics guys, most users to the website often are in that 320px dimension, see the data table below

Image

Tosin-Balogun commented 1 year ago

The interaction points work very well.

Tosin-Balogun commented 1 year ago

Image

The elements accommodates multiple lines well

Tosin-Balogun commented 1 year ago

The addition and removal of more checkboxes work well.

Tosin-Balogun commented 1 year ago

I'm unsure how to simulate the error state if it to be used in an interaction mode. It does work, just thinking about when someone actually is trying to simulate an error state, what would they do to allow it to transition if a research participant was fiddling with it.

I'd imagine they can make multiple pages that has the two different variant states, but just wondering if the component itself can be swapped out, just a thought