AsahiLinux / asahi-installer

Asahi Linux installer
MIT License
807 stars 107 forks source link

feature: prevent Asahi volumes from auto-mount on macOS #306

Closed PaulCharlton closed 3 months ago

PaulCharlton commented 3 months ago

feature: prevent Asahi volumes from auto-mount on macOS

proposed: for each volume created by Asahi Installer:

echo UUID=<volume uuid> none auto noauto >> /etc/fstab

related to #294, but different, since auto mounted drives still may be hidden from finder. this will prevent them from auto mounting and being available in the command console or other programs.

PaulCharlton commented 3 months ago

PR forthcoming

PaulCharlton commented 3 months ago

would be more complete to verify that the UUID is not already in /etc/fstab in order to be more safe.

jannau commented 3 months ago

Is this a an important problem? Currently we leave macos installations untouched (ignoring the resize). This seems to be better handled via documentation.

PaulCharlton commented 3 months ago

is important ... the extra volumes: 1) present a risk of user modification to the Asahi instance through Finder/Terminal etc [visibility in macOS is actually a change to macOS] 2) get indexed by Spotlight [changing the underlying macOS behavior] 3) the APFS volumes get added to TimeMachine and get snapshots [changing the underlying macOS behavior]

which is the lesser of two evils? 1) modifying /etc/fstab to prevent new behaviors 2) allowing TimeMachine, Spotlight, Finder, Terminal to change their pre-Asahi behaviors?

@jannau

marcan commented 3 months ago

The Spotlight/TimeMachine issue can be solved with the other approach you mentioned. I do not agree with messing with /etc/fstab.