toil: update all shell scripts to pass static analysis with shellcheck SC2223

[PaulCharlton]

toil: update all shell scripts to pass static analysis with shellcheck SC2223

This will be submitted as multiple related issues, with a PR for each of those as there are 448 issues in the various scripts. In order to bring that down to a reviewable scope, each separate PR is planned as follows:

1) SC1091 (info): Not following: ./.cargo/env was not specified as input (see shellcheck -x). 1) SC2034 (warning): appears unused. Verify use (or export if used externally). 1) SC2046 (warning): Quote this to prevent word splitting. 1) SC2048 (warning): Use "$@" (with quotes) to prevent whitespace problems. 1) SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo". 1) SC2086 (info): Double quote to prevent globbing and word splitting. 1) SC2153 (info): Possible misspelling: DECDEV may not be assigned. Did you mean SECDEV? 1) SC2162 (info): read without -r will mangle backslashes. 1) SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails. 1) SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.

[marcan]

WTF. You opened 9 identical issues. Please don't spam our issue tracker. If you do this again I will ban you from the organization.

[PaulCharlton]

@marcan -- perhaps some discussion in order. I really did not want to load up approx 500 patches for syntax and safety static checks -- in my experience, most people prefer to take bite-size pieces for code review, organized by some related principal that makes each subset easy to digest.

I grouped them as separate issues on purpose for a separation of concerns to make code review easier.

how would you like to proceed?

[marcan]

I would not like to proceed. I've wasted enough time on the issue tracker today already. Please stop.