AsahiLinux / asahi-scripts

Miscellaneous admin scripts for the Asahi Linux reference distro
MIT License
45 stars 32 forks source link

first-boot: use mlabel to randomize efi #22

Closed dkwo closed 4 weeks ago

dkwo commented 1 year ago

Does this make sense?

Skirmisher commented 1 year ago

Using -n instead of -N causes mlabel to generate a new serial itself, allowing you to drop the call to uuidgen. However, mtools is not present on the base Asahi Linux install, so this wouldn't be suitable for a distro script unless it were added as a base dependency. As an alternative, though, dosfstools includes the fatlabel utility which can do the same thing (fatlabel --volume-id --reset). Now, dosfstools isn't in the base system either, but it also includes fsck.fat and mkfs.fat, which I think makes a strong argument for requiring the package, considering a working ESP is effectively required for Asahi.

Conan-Kudo commented 1 year ago

I think it's reasonable to depend on either mtools or dosfstools. The likelihood of the latter already being present is pretty high, though.

tobhe commented 1 year ago

I think it's reasonable to depend on either mtools or dosfstools. The likelihood of the latter already being present is pretty high, though.

Agree. My preference would also be dosfstools/fatlabel because that is more widely available by default.

marcan commented 4 weeks ago

Closing because this script is basically specific to the deprecated Arch setup. We talked about UUID randomization and agreed it has to be done in the initramfs so it can happen prior to partition mount, to make it work for btrfs.