search

AsahiLinux / asahi-scripts

Miscellaneous admin scripts for the Asahi Linux reference distro
MIT License
46 stars 31 forks source link

fix: explicit use bash for update-grub #23

Open cyrinux opened 1 year ago

cyrinux commented 1 year ago

I use dash as /bin/sh on my system.

Actual script is not posix compliant some piece of code are bash only, I propose to just force /bin/bash here.

Or we should convert them all to posix, in case some people, use dash for example.

tobhe commented 1 year ago

+1, also had to patch this in my Ubuntu package.

dkwo commented 6 months ago

I think also update-m1n1 is bash specific?

tobhe commented 6 months ago

@dkwo indeed

dkwo commented 6 months ago

Actually i think i was wrong. For me, the issue is that m1n1.conf needs to have an end of line, otherwise it is not processed. i'm using a slightly modified version, but it works with /bin/sh on void, which is dash i think. the example in the wiki is bash though, with the <(.. construct.

tobhe commented 6 months ago

@dkwo looks like it was fixed in https://github.com/AsahiLinux/asahi-scripts/commit/6d2a484e7ed1658f8e5f24406a5610bfe0b2a8e3. I was still carrying a diff to change the shebang line. I guess I can drop that.

dkwo commented 4 months ago

it was reported that also asahi-diagnose has bashisms, do you mind changing its to bash as well in this pr?