search

AsahiLinux / linux

Linux kernel source tree
Other
2.17k stars 84 forks source link

[brcmfmac] Fix two issues discovered by smatch #218

Closed dberlin closed 7 months ago

dberlin commented 8 months ago

This PR fixes two issues discovered by smatch testing

The first is that the 6g bwcap logic was incorrect - the function has now been refactored to make the logic obvious.

The second is that the code was not defensive enough when the wrong netinfo retrieval function was used. A user should never hit this as the messages are only intended for developers (and wifi would be non-functional if you screwed this up in the driver) but the code has been made more defensive to avoid crashing in this case.

marcan commented 7 months ago

I think we need signoffs on these :) (and some of the other PRs)

dberlin commented 7 months ago

I'm on it

Sent from Gmail Mobile

On Fri, Nov 3, 2023 at 9:20 AM Hector Martin @.***> wrote:

I think we need signoffs on these :) (and some of the other PRs)

— Reply to this email directly, view it on GitHub https://github.com/AsahiLinux/linux/pull/218#issuecomment-1792425517, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACPI243EZCGXAPNGSUM2VDYCTVQ3AVCNFSM6AAAAAA6CDNPXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJSGQZDKNJRG4 . You are receiving this because you authored the thread.Message ID: @.***>

dberlin commented 7 months ago

I'm gonna drop this one in favor of some better patches in the first place for you to merge