chadmed
commented
1 week ago I am very unhappy with how we are handling the "shared" keys here. There doesn't seem to be much at all in common between logic boards, even keys you'd expect wouldn't change. I don't think having a series of cascaded includes is worth it given how wildly the boards seem to differ, and we should probably just specify the keys directly at the highest level we can empirically demonstrate that they are shared, e.g. t600x-j314-j416.dtsi
As it says on the tin, just an RFC for an improved hwmon driver which pulls data from the SMC.
The only real major issue is that there seems to be no reliable or accurate source of information for which keys are present on which machine. The data in this MR comes mostly from poking around with m1n1 on various devices. Some additional sensors come from exelban/stats, however granularity at the SoC level seems insufficient as many devices are missing sensors which are supposed to be there (e.g. random CPU core temperatures).
My preferred approach for this would be to simply ditch the attempt to keep SMC sensors in
.dtsifiles and just experimentally determine which are present on each device (or class of device) and populate&smcat that level.