search

AsahiLinux / speakersafetyd

Rust speaker safety daemon for Asahi Linux
MIT License
119 stars 7 forks source link

/var FHS violation for blackbox directory #3

Closed andhe closed 9 months ago

andhe commented 10 months ago

When looking at packaging speakersafetyd for Debian, lintian (the debian package linter) had this to say about the package:

E: speakersafetyd: non-standard-dir-in-var [var/speakersafetyd/] N: N: The FHS says "Applications should generally not add directories to the top N: level of /var. Such directories should only be added if they have some N: system-wide implication, and in consultation with the FHS mailing list." N: N: Please refer to The /var Hierarchy (Chapter 5) in the Filesystem Hierarchy N: Standard for details. N: N: Visibility: error N: Show-Always: no N: Check: files/hierarchy/standard

Maybe use /var/cache/... (or possibly /var/lib/...)?

May I also suggest shipping a tmpfiles.d snippet to create directories under /var instead of (or in addition to) shipping the directory in the package? This would allow the directory to be recreated automatically(with proper permissions) in case state files are ever removed, without having to reinstall the package.

andhe commented 10 months ago

Seems like the shipped speakersafetyd.service already uses /var/lib, so this is just a typo in the Makefile.