search

AsaiToshiya / brostr

A native browser for the content on Nostr
https://asaitoshiya.github.io/brostr/src/
MIT License
12 stars 0 forks source link

Fix issue: issue#31 #33

Closed Vvinathi closed 1 year ago

Vvinathi commented 1 year ago

I have fixed the issue by updating the favicon file paths in the HTML code. I hope it solves the issue?

AsaiToshiya commented 1 year ago

Usually correct fix, but those paths cannot referenced in https://asaitoshiya.github.io/brostr/src/ on GitHub Pages.

AsaiToshiya commented 1 year ago

You also need to fix the following:

https://github.com/AsaiToshiya/brostr/blob/2e97e6606e26eb9b3a496b2e61485f94c149009e/src/index.html#L21-L22

AsaiToshiya commented 1 year ago

I think you can fix this by using /brostr/images/apple-touch-icon.png or ../images/apple-touch-icon.png.

AsaiToshiya commented 1 year ago

@Vvinathi Thank you for fix. I merged it into main.

Vvinathi commented 1 year ago

Thanks a lot @AsaiToshiya.