AsamK / signal-cli

signal-cli provides an unofficial commandline, JSON-RPC and dbus interface for the Signal messenger.
GNU General Public License v3.0
3.17k stars 299 forks source link

Cannot register with signal-cli 0.13.1 #1491

Open bublath opened 6 months ago

bublath commented 6 months ago

I got reports from my users that they failed to register with "Error in registerWithCaptcha:Invalid captcha given." I can reproduce this both using Dbus and directly from CLI. Tried captchas from both sources given in the Wiki, immediately used "copy link" on the "Open Signal" URL which got me something like signalcaptcha://signal-hcaptcha-short.5fad97ac-7d06-4e44-b18a-b950b20148ff.registration.pYpZRKG_y9w2jtsiMglF9ODo and used it with signal-cli (method SMS) The number I'm trying to register is a German landline - so I was planning to use "voice" in a second step, but never get that far. After several attemps I'm getting "Failed to register: StatusCode: 429 (RegistrationRetryException)" which is an indication that the server really got my registration attemps.

icacrr commented 6 months ago

I've the same two issues. I'm using signal-cli 0.13.1 and the SMS method.

  1. Sometime the captcha, even if well completed, return an invalid token. In the firefox console log, I can see that, when the token is invalid, I have only the warning "Prevented navigation to “signalcaptcha://signal-hcaptcha.XXXXX" (yellow) and not the log "Navigated to signalcaptcha://signal-hcaptcha.XXXXX" (blue).

  2. When I got a valid captcha token, the register command respond "Failed to register: StatusCode: 429 (RegistrationRetryException)". Here is the command result with verbose log:

$ signal-cli -v -u +XXXXXXX register --captcha signal-hcaptcha.XXX
2024-03-21T16:01:04.092Z [main] DEBUG org.asamk.signal.util.IOUtils - XDG_RUNTIME_DIR not set, falling back to temp dir
2024-03-21T16:01:04.093Z [main] DEBUG org.asamk.signal.App - Starting signal-cli 0.13.1
2024-03-21T16:01:06.037Z [main] INFO  LibSignal - [libsignal]: rust/bridge/jni/src/logging.rs:158: Initializing libsignal version:0.39.2
2024-03-21T16:01:06.037Z [main] DEBUG org.asamk.signal.util.IOUtils - XDG_DATA_HOME not set, falling back to home dir
2024-03-21T16:01:06.072Z [main] INFO  com.zaxxer.hikari.HikariDataSource - HikariPool-1 - Starting...
2024-03-21T16:01:06.145Z [main] INFO  com.zaxxer.hikari.pool.HikariPool - HikariPool-1 - Added connection org.sqlite.jdbc4.JDBC4Connection@770e93b6
2024-03-21T16:01:06.145Z [main] INFO  com.zaxxer.hikari.HikariDataSource - HikariPool-1 - Start completed.
2024-03-21T16:01:07.092Z [main] DEBUG org.asamk.signal.manager.util.Utils - Invalid locale 'en', using fallback: en_US
2024-03-21T16:01:07.398Z [main] INFO  com.zaxxer.hikari.HikariDataSource - HikariPool-1 - Shutdown initiated...
2024-03-21T16:01:07.399Z [main] INFO  com.zaxxer.hikari.HikariDataSource - HikariPool-1 - Shutdown completed.
Failed to register: StatusCode: 429 (RegistrationRetryException)
org.whispersystems.signalservice.api.push.exceptions.RegistrationRetryException: StatusCode: 429
    at org.whispersystems.signalservice.internal.push.PushServiceSocket$RegistrationCodeRequestResponseHandler.handle(PushServiceSocket.java:2958)
    at org.whispersystems.signalservice.internal.push.PushServiceSocket.makeServiceRequest(PushServiceSocket.java:2130)
    at org.whispersystems.signalservice.internal.push.PushServiceSocket.requestVerificationCode(PushServiceSocket.java:403)
    at org.whispersystems.signalservice.api.SignalServiceAccountManager.requestSmsVerificationCode(SignalServiceAccountManager.java:283)
    at org.asamk.signal.manager.util.NumberVerificationUtils.requestVerificationCode(NumberVerificationUtils.java:98)
    at org.asamk.signal.manager.internal.RegistrationManagerImpl.register(RegistrationManagerImpl.java:136)
    at org.asamk.signal.commands.RegisterCommand.register(RegisterCommand.java:75)
    at org.asamk.signal.commands.RegisterCommand.handleCommand(RegisterCommand.java:51)
    at org.asamk.signal.commands.CommandHandler.handleRegistrationCommand(CommandHandler.java:31)
    at org.asamk.signal.App.handleRegistrationCommand(App.java:265)
    at org.asamk.signal.App.handleCommand(App.java:174)
    at org.asamk.signal.App.init(App.java:144)
    at org.asamk.signal.Main.main(Main.java:56)
    at java.base@21.0.2/java.lang.invoke.LambdaForm$DMH/sa346b79c.invokeStaticInit(LambdaForm$DMH)
kjcole commented 5 months ago

This persists in 0.13.3.

orazioedoardo commented 4 months ago

CAPTCHA registration works for me on 0.13.3. Have you tried enclosing the captcha URI in single quotes? Perhaps there are some shell characters in the token.

roymasad commented 3 months ago

same issue with version 0.13.4

Geremia commented 3 months ago

@orazioedoardo Enclosed in quotes or not, I get this issue, too, with master (0.13.5-SNAPSHOT). I'm able to register on an Android device, so this issue seems specific to signal-cli.

icacrr commented 3 months ago

This persists in version 0.13.4 (I tried with a debian and a ubuntu).

Geremia commented 3 months ago

It worked for me today, after waiting a few days (perhaps it is a rate-limiting issue on Signal server's end and not a signal-cli issue):

signal-cli -a +1XXXXXXXXXX -vv register --captcha signalcaptcha://signal-hcaptcha.[…]

``` 2024-07-03T11:19:38.709-0700 [main] DEBUG org.asamk.signal.App - Starting signal-cli 0.13.5-SNAPSHOT 2024-07-03T11:19:39.040-0700 [main] TRACE org.asamk.signal.manager.Manager - Expected exception when checking libsignal-client: Failed to deserialize zkgroup::api::groups::uuid_ciphertext::UuidCiphertext 2024-07-03T11:19:39.040-0700 [main] DEBUG org.asamk.signal.util.IOUtils - XDG_DATA_HOME not set, falling back to home dir 2024-07-03T11:19:39.357-0700 [main] TRACE o.a.s.manager.storage.SignalAccount - Opening account file 2024-07-03T11:19:39.360-0700 [main] TRACE o.a.s.manager.storage.SignalAccount - Loading account file 372472 2024-07-03T11:19:39.436-0700 [main] INFO com.zaxxer.hikari.HikariDataSource - HikariPool-1 - Starting... 2024-07-03T11:19:39.582-0700 [main] INFO com.zaxxer.hikari.pool.HikariPool - HikariPool-1 - Added connection org.sqlite.jdbc4.JDBC4Connection@47a86fbb 2024-07-03T11:19:39.584-0700 [main] INFO com.zaxxer.hikari.HikariDataSource - HikariPool-1 - Start completed. 2024-07-03T11:19:39.594-0700 [main] TRACE o.a.s.m.storage.AccountDatabase - Current database version: 26 Program database version: 26 2024-07-03T11:19:41.381-0700 [main] TRACE org.asamk.signal.manager.util.Utils - Using default locale: en_US (en-US) 2024-07-03T11:19:41.890-0700 [main] INFO com.zaxxer.hikari.HikariDataSource - HikariPool-1 - Shutdown initiated... 2024-07-03T11:19:41.892-0700 [main] INFO com.zaxxer.hikari.HikariDataSource - HikariPool-1 - Shutdown completed. ```

signal-cli -a +1XXXXXXXXXX -vv verify XXXXXX

``` 2024-07-03T11:26:13.579-0700 [main] DEBUG org.asamk.signal.App - Starting signal-cli 0.13.5-SNAPSHOT 2024-07-03T11:26:13.904-0700 [main] TRACE org.asamk.signal.manager.Manager - Expected exception when checking libsignal-client: Failed to deserialize zkgroup::api::groups::uuid_ciphertext::UuidCiphertext 2024-07-03T11:26:13.904-0700 [main] DEBUG org.asamk.signal.util.IOUtils - XDG_DATA_HOME not set, falling back to home dir 2024-07-03T11:26:14.212-0700 [main] TRACE o.a.s.manager.storage.SignalAccount - Opening account file 2024-07-03T11:26:14.214-0700 [main] TRACE o.a.s.manager.storage.SignalAccount - Loading account file 372472 2024-07-03T11:26:14.289-0700 [main] INFO com.zaxxer.hikari.HikariDataSource - HikariPool-1 - Starting... 2024-07-03T11:26:14.434-0700 [main] INFO com.zaxxer.hikari.pool.HikariPool - HikariPool-1 - Added connection org.sqlite.jdbc4.JDBC4Connection@47a86fbb 2024-07-03T11:26:14.435-0700 [main] INFO com.zaxxer.hikari.HikariDataSource - HikariPool-1 - Start completed. 2024-07-03T11:26:14.445-0700 [main] TRACE o.a.s.m.storage.AccountDatabase - Current database version: 26 Program database version: 26 2024-07-03T11:26:16.458-0700 [main] DEBUG o.a.s.m.s.r.MergeRecipientHelper - Got existing recipient RecipientId[id=1], updating with high trust address 2024-07-03T11:26:16.531-0700 [main] DEBUG o.a.s.manager.storage.SignalAccount - Adding ACI signed pre key with offset 3811068 2024-07-03T11:26:16.562-0700 [main] DEBUG o.a.s.manager.storage.SignalAccount - Adding ACI last resort kyber pre key with offset 2367354 2024-07-03T11:26:16.599-0700 [main] DEBUG o.a.s.manager.storage.SignalAccount - Adding PNI signed pre key with offset 10035756 2024-07-03T11:26:16.628-0700 [main] DEBUG o.a.s.manager.storage.SignalAccount - Adding PNI last resort kyber pre key with offset 16689171 2024-07-03T11:26:16.721-0700 [main] DEBUG o.a.s.m.s.i.IdentityKeyStore - Storing new identity for recipient 8e250cfa-877e-40de-96b5-848f0f80fdb4 with trust TRUSTED_UNVERIFIED 2024-07-03T11:26:16.721-0700 [main] TRACE o.a.s.m.s.i.IdentityKeyStore - Storing identity info for 8e250cfa-877e-40de-96b5-848f0f80fdb4, trust: TRUSTED_UNVERIFIED, added: 1720031176721 2024-07-03T11:26:16.772-0700 [main] DEBUG o.a.s.m.s.i.IdentityKeyStore - Updating trust level for recipient 8e250cfa-877e-40de-96b5-848f0f80fdb4 with trust TRUSTED_VERIFIED 2024-07-03T11:26:16.773-0700 [main] TRACE o.a.s.m.s.i.IdentityKeyStore - Storing identity info for 8e250cfa-877e-40de-96b5-848f0f80fdb4, trust: TRUSTED_VERIFIED, added: 1720031176721 2024-07-03T11:26:16.820-0700 [main] DEBUG o.a.s.m.s.i.IdentityKeyStore - Storing new identity for recipient PNI:66a3a46e-223d-4c8e-964f-5458d2fe20d7 with trust TRUSTED_UNVERIFIED 2024-07-03T11:26:16.820-0700 [main] TRACE o.a.s.m.s.i.IdentityKeyStore - Storing identity info for PNI:66a3a46e-223d-4c8e-964f-5458d2fe20d7, trust: TRUSTED_UNVERIFIED, added: 1720031176820 2024-07-03T11:26:16.868-0700 [main] DEBUG o.a.s.m.s.i.IdentityKeyStore - Updating trust level for recipient PNI:66a3a46e-223d-4c8e-964f-5458d2fe20d7 with trust TRUSTED_VERIFIED 2024-07-03T11:26:16.868-0700 [main] TRACE o.a.s.m.s.i.IdentityKeyStore - Storing identity info for PNI:66a3a46e-223d-4c8e-964f-5458d2fe20d7, trust: TRUSTED_VERIFIED, added: 1720031176820 2024-07-03T11:26:17.237-0700 [main] DEBUG o.a.s.manager.helper.PreKeyHelper - Refreshing ACI ec pre keys, because only 0 of min 10 pre keys remain 2024-07-03T11:26:17.249-0700 [main] DEBUG o.a.s.manager.helper.PreKeyHelper - Refreshing ACI kyber pre keys, because only 0 of min 10 pre keys remain 2024-07-03T11:26:17.887-0700 [main] DEBUG o.a.s.manager.storage.SignalAccount - Adding 100 ACI pre keys with offset 6722942 2024-07-03T11:26:20.352-0700 [main] DEBUG o.a.s.manager.storage.SignalAccount - Adding 100 ACI kyber pre keys with offset 2367355 2024-07-03T11:26:22.849-0700 [main] DEBUG o.a.s.manager.helper.PreKeyHelper - Refreshing PNI ec pre keys, because only 0 of min 10 pre keys remain 2024-07-03T11:26:22.860-0700 [main] DEBUG o.a.s.manager.helper.PreKeyHelper - Refreshing PNI kyber pre keys, because only 0 of min 10 pre keys remain 2024-07-03T11:26:23.453-0700 [main] DEBUG o.a.s.manager.storage.SignalAccount - Adding 100 PNI pre keys with offset 9948765 2024-07-03T11:26:26.009-0700 [main] DEBUG o.a.s.manager.storage.SignalAccount - Adding 100 PNI kyber pre keys with offset 16689172 2024-07-03T11:26:28.548-0700 [main] TRACE o.a.s.m.h.UnidentifiedAccessHelper - Unidentified access not available for RecipientId[id=1] 2024-07-03T11:26:28.548-0700 [main] TRACE o.a.s.manager.helper.ProfileHelper - Retrieving profile for RecipientId[id=1] with profile key 2024-07-03T11:26:28.573-0700 [main] TRACE org.asamk.signal.manager.util.Utils - Using default locale: en_US (en-US) 2024-07-03T11:26:28.701-0700 [main] TRACE o.a.s.manager.helper.ProfileHelper - Got new profile for RecipientId[id=1] 2024-07-03T11:26:28.702-0700 [main] TRACE o.a.s.manager.helper.ProfileHelper - Storing profile credential 2024-07-03T11:26:28.702-0700 [main] TRACE o.a.s.manager.helper.ProfileHelper - Decrypting profile 2024-07-03T11:26:28.702-0700 [main] TRACE o.a.s.manager.helper.ProfileHelper - Downloading profile avatar for RecipientId[id=1] 2024-07-03T11:26:28.754-0700 [main] TRACE o.a.s.manager.helper.ProfileHelper - Storing identity 2024-07-03T11:26:28.754-0700 [main] TRACE o.a.s.m.s.i.IdentityKeyStore - Not storing new identity for recipient 8e250cfa-877e-40de-96b5-848f0f80fdb4, identity already stored 2024-07-03T11:26:28.754-0700 [main] TRACE o.a.s.manager.helper.ProfileHelper - Storing profile 2024-07-03T11:26:28.801-0700 [main] DEBUG o.a.s.m.s.recipients.RecipientStore - Marking RecipientId[id=1] as registered=true 2024-07-03T11:26:28.801-0700 [main] TRACE o.a.s.manager.helper.ProfileHelper - Done handling retrieved profile 2024-07-03T11:26:28.804-0700 [main] DEBUG o.a.s.manager.helper.ProfileHelper - Uploading new profile 2024-07-03T11:26:28.930-0700 [main] TRACE o.a.signal.manager.helper.SendHelper - Not sending sync message because there are no linked devices. 2024-07-03T11:26:28.931-0700 [main] INFO com.zaxxer.hikari.HikariDataSource - HikariPool-1 - Shutdown initiated... 2024-07-03T11:26:28.933-0700 [main] INFO com.zaxxer.hikari.HikariDataSource - HikariPool-1 - Shutdown completed. ```

(phone numbers, full captcha, and verify code redacted)

icacrr commented 2 months ago

Logs of CAPTCHA registration, with signal-cli version 13.4. CAPTCHA generated with https://signalcaptchas.org/registration/generate (with same IP than signa-cli)

$ signal-cli -u +1XXXXXXXXXX -vv register --captcha signalcaptcha://signal-hcaptcha.[...]
2024-07-10T16:12:39.090Z [main] DEBUG org.asamk.signal.util.IOUtils - XDG_RUNTIME_DIR not set, falling back to temp dir
2024-07-10T16:12:39.090Z [main] DEBUG org.asamk.signal.App - Starting signal-cli 0.13.4
2024-07-10T16:12:50.759Z [main] INFO  LibSignal - [libsignal]: rust/bridge/jni/src/logging.rs:161: Initializing libsignal version:0.47.0
2024-07-10T16:12:50.759Z [main] TRACE org.asamk.signal.manager.Manager - Expected exception when checking libsignal-client: Failed to deserialize zkgroup::api::groups::uuid_ciphertext::UuidCiphertext
2024-07-10T16:12:50.759Z [main] DEBUG org.asamk.signal.util.IOUtils - XDG_DATA_HOME not set, falling back to home dir
2024-07-10T16:12:50.767Z [main] TRACE o.a.s.manager.storage.SignalAccount - Opening account file
2024-07-10T16:12:50.767Z [main] TRACE o.a.s.manager.storage.SignalAccount - Loading account file 269669
2024-07-10T16:12:50.769Z [main] INFO  com.zaxxer.hikari.HikariDataSource - HikariPool-1 - Starting...
2024-07-10T16:12:50.837Z [main] INFO  com.zaxxer.hikari.pool.HikariPool - HikariPool-1 - Added connection org.sqlite.jdbc4.JDBC4Connection@6f98ba07
2024-07-10T16:12:50.837Z [main] INFO  com.zaxxer.hikari.HikariDataSource - HikariPool-1 - Start completed.
2024-07-10T16:12:50.837Z [main] TRACE o.a.s.m.storage.AccountDatabase - Current database version: 26 Program database version: 26
2024-07-10T16:12:52.881Z [main] DEBUG o.a.s.m.i.RegistrationManagerImpl - Failed to reactivate account
2024-07-10T16:12:53.864Z [main] INFO  com.zaxxer.hikari.HikariDataSource - HikariPool-1 - Shutdown initiated...
2024-07-10T16:12:53.866Z [main] INFO  com.zaxxer.hikari.HikariDataSource - HikariPool-1 - Shutdown completed.
Invalid captcha given.

Same with enclosed single quotes


signal-cli -u +1XXXXXXXXXX -vv register --captcha 'signalcaptcha://signal-hcaptcha.[...]
2024-07-10T16:36:37.534Z [main] DEBUG org.asamk.signal.util.IOUtils - XDG_RUNTIME_DIR not set, falling back to temp dir
2024-07-10T16:36:37.535Z [main] DEBUG org.asamk.signal.App - Starting signal-cli 0.13.4
2024-07-10T16:36:46.633Z [main] INFO  LibSignal - [libsignal]: rust/bridge/jni/src/logging.rs:161: Initializing libsignal version:0.47.0
2024-07-10T16:36:46.634Z [main] TRACE org.asamk.signal.manager.Manager - Expected exception when checking libsignal-client: Failed to deserialize zkgroup::api::groups::uuid_ciphertext::UuidCiphertext
2024-07-10T16:36:46.634Z [main] DEBUG org.asamk.signal.util.IOUtils - XDG_DATA_HOME not set, falling back to home dir
2024-07-10T16:36:46.658Z [main] TRACE o.a.s.manager.storage.SignalAccount - Opening account file
2024-07-10T16:36:46.658Z [main] TRACE o.a.s.manager.storage.SignalAccount - Loading account file 269669
2024-07-10T16:36:46.662Z [main] INFO  com.zaxxer.hikari.HikariDataSource - HikariPool-1 - Starting...
2024-07-10T16:36:46.732Z [main] INFO  com.zaxxer.hikari.pool.HikariPool - HikariPool-1 - Added connection org.sqlite.jdbc4.JDBC4Connection@1ef08f92
2024-07-10T16:36:46.732Z [main] INFO  com.zaxxer.hikari.HikariDataSource - HikariPool-1 - Start completed.
2024-07-10T16:36:46.732Z [main] TRACE o.a.s.m.storage.AccountDatabase - Current database version: 26 Program database version: 26
2024-07-10T16:36:47.697Z [main] DEBUG o.a.s.m.i.RegistrationManagerImpl - Failed to reactivate account
2024-07-10T16:36:48.750Z [main] DEBUG o.a.s.m.util.NumberVerificationUtils - No registration session, creating new one.
2024-07-10T16:36:51.786Z [main] INFO  com.zaxxer.hikari.HikariDataSource - HikariPool-1 - Shutdown initiated...
2024-07-10T16:36:51.789Z [main] INFO  com.zaxxer.hikari.HikariDataSource - HikariPool-1 - Shutdown completed.