AsamK / signal-cli

signal-cli provides an unofficial commandline, JSON-RPC and dbus interface for the Signal messenger.
GNU General Public License v3.0
3.17k stars 299 forks source link

addDevice not accepting "device link" #1562

Closed ilippert closed 1 month ago

ilippert commented 1 month ago

The problem: addDevice does not lead to expected result

Chatter: Thanks so much for signal-cli!

This is how the problem (repeatedly) appears, some things work, some don't:

signal-cli -u +49XXXXX addDevice --uri 'sgnl://linkdevice?uuid=....&pub_key=....'

generates as a result

ERROR AddDeviceCommand - Invalid device link
Invalid device link

I tried the sgnl://linkdevice?uuid=....&pub_key=.... identifiers multiple times (restart a linux Signal Desktop app, scanning the QR code, pasting in the shell within the '...').

I suspect that --uri 'sgnl://linkdevice?uuid=....&pub_key=....' has to include the &pub_key=.... component, but am not actually sure. If it is correct, then https://github.com/AsamK/signal-cli/pull/1561 may be helping others to be certain they are pasting the correct string.

I guess following https://github.com/AsamK/signal-cli/issues/139 that % should not be an issue.

I am grateful for questions that help me revise this issue so that it becomes legible and productive.

ilippert commented 1 month ago

Found the solution, it was the problem, that I extracted &amp from the QR code and used that instead of the required &.