Asana / locheck

Validate iOS, Android, and Mac localizations. Find errors in .strings, .stringsdict, and strings.xml files.
MIT License
97 stars 11 forks source link

Provide ability to validate base language w/ out comparison #13

Closed namolnad closed 3 years ago

namolnad commented 3 years ago

It would be nice if the tool could validate the base language without comparing it to translations to see if there are issues with things like position identifiers within stringsdict files. This would be great as an initial check that things are being properly formatted before being sent to translators, for instance.

stevelandeyasana commented 3 years ago

Would the --ignore-missing option in #11 solve this problem for you? It discards warnings related to strings appearing in one localization but not another.

An easy fix would be to just stop throwing errors if no translations are passed, and just run the internal validation on the base language.

namolnad commented 3 years ago

I do think that would likely work for my team's needs — it might not be quite as clear from a user perspective as the second option you've presented, but I think it would work. Either way, thanks for considering and for your work on this!

stevelandeyasana commented 3 years ago

Will be fixed by #17.

namolnad commented 3 years ago

Thanks for the fix/addition!