search

Asana / locheck

Validate iOS, Android, and Mac localizations. Find errors in .strings, .stringsdict, and strings.xml files.
MIT License
96 stars 10 forks source link

discoverlproj fails with space in dir name #46

Closed philmitchell closed 1 year ago

philmitchell commented 1 year ago

The xcstrings command works, but discoverlproj fails with a "File does not exist" error.

This is on MacOS.

Thanks for the invaluable tool!

stevelandeyasana commented 1 year ago

Can you please paste the full command you're running, and what the lproj paths are in your source tree?

philmitchell commented 1 year ago

locheck discoverlproj "/Users/phil/dev/client_repo/source\ dir"

/Users/phil/dev/client_repo/source\ dir/Base.lproj/ /Users/phil/dev/client_repo/source\ dir/English.lproj/ /Users/phil/dev/client_repo/source\ dir/en-AU.lproj/ /Users/phil/dev/client_repo/source\ dir/en-GB.lproj/ /Users/phil/dev/client_repo/source\ dir/en-NZ.lproj/ /Users/phil/dev/client_repo/source\ dir/en.lproj/

stevelandeyasana commented 1 year ago

Yeah, that does look correct. I'll look into this some time in the next couple weeks, though if you're feeling adventurous, you could check out the code and add some breakpoints here: https://github.com/Asana/locheck/blob/main/Sources/LocheckCommand/main.swift#L319

stevelandeyasana commented 1 year ago

Oh, I just realized - your shell command includes a \ in the quoted string, which isn't necessary. You either need quotes, or the backslash. Could you please try removing either one?

philmitchell commented 1 year ago

Steve, you are right ... it works fine. Sorry for the noise and thanks for the quick response!

stevelandeyasana commented 1 year ago

No problem!