search

Asana / php-asana

Official PHP client library for the Asana API v1
MIT License
136 stars 59 forks source link

Fix compatibility with PHP 8.1 #103

Closed TheMY3 closed 2 years ago

TheMY3 commented 2 years ago

@jv-asana need one more approve from you :) All fine with https://github.com/Asana/php-asana/pull/98 and https://github.com/Asana/php-asana/pull/97, but need to specify root namespace, for now we still got warning.

P.S. And we got warnings from depended package - nategood/httpful (same warnings), but that library looks like abandoned, I can fork it and make fixes if you want, and create PR with new fixed dependency.

jv-asana commented 2 years ago

Hi @TheMY3 thank you contributing to the php-asana client library. At some point we will want to declare return types rather than suppressing these warnings. I can approve your PR. Also, that would be great if you can send a fix for the nategood/httpful package :)