Add full compatibility with PHP 8.1

Asana / php-asana

Official PHP client library for the Asana API v1

MIT License

136 stars 59 forks source link

Add full compatibility with PHP 8.1 #104

Closed TheMY3 closed 2 years ago

TheMY3 commented 2 years ago

@jv-asana hello again :)

As you said in this https://github.com/Asana/php-asana/pull/103#issuecomment-1287284468 I created fork with fixes for 8.1.

jv-asana commented 2 years ago

Hey @TheMY3, I discussed this PR with my team and we really appreciate this contribution. We did a more thorough review and concluded that it would be better for us to fix this issue ourselves. Apologies for the work you have had to put into this. With that said, we're not going to merge this PR at this time, but we can update you on when we will support PHP 8.1 properly. Thanks again for the contribution, and please keep the feedback coming!

TheMY3 commented 2 years ago

@jv-asana ok, good news for me)