search

Asana / ruby-asana

Official Ruby client library for the Asana API v1
MIT License
77 stars 54 forks source link

Added support for Faraday 2 #152

Closed igor-alexandrov closed 1 year ago

igor-alexandrov commented 1 year ago

This PR adds support for Faraday 2 to asana gem (#141).

All specs pass, I've also tested this in my project and everything works well.

Let's discuss.

jv-asana commented 1 year ago

@igor-alexandrov Thank you for sending this PR. Do you also mind updating the Appraisals file. I think the GitHub action builds are failing because of it.

igor-alexandrov commented 1 year ago

@jv-asana added two latest faraday version to Appraisals.

igor-alexandrov commented 1 year ago

@jv-asana will you also release gem to Rubygems?

jv-asana commented 1 year ago

@jv-asana will you also release gem to Rubygems?

Hi @igor-alexandrov I was going to wait until we update our library with new endpoints but I can go ahead and release it now instead of waiting.

igor-alexandrov commented 1 year ago

@jv-asana no reason to rush, release it when you consider the right time to do this.