AscendingCreations / AxumSession

Axum Session Management Libraries that use Sqlx
MIT License
142 stars 29 forks source link

Is it possible to have the async runtime and tls crate to be "features" in Cargo.toml #3

Closed apps4uco closed 2 years ago

apps4uco commented 2 years ago

Hi, hope you dont mind me submitting an issue on a pre release crate...

I ran into the problem that I was using native-tls in my project and encountered the problem that "runtime-tokio-rustls" is currently hard coded in AxumSessions Cargo.toml

In my case I could solve it by changing to rustls in my project as the other crates I am using do not hard code the async runtime + tls crate. However, it is not always the case with all crates.

Would it be possible to change this to be a feature like in the sqlx crate.

genusistimelord commented 2 years ago

Yes I will be allowing switching between Rustls and native since they both are important to have due to some OS limitations. I just have it preset to Rustls for testing only. Thank you for looking into my library. Feel free to push Pull requests for new additions or fixes to these things. Otherwise I will get around to these when I can.

Also feel free to look at my other 2 library's for Axum that I have worked on as well.

https://github.com/AscendingCreations/AxumSqlxSessionAuth which will be renamed to AxumSessionAuth soon once this library is ready and released. This library is for user login and logout authentication and can auto load the account on login if they have logged in before. It uses AxumSessions to handle all the login data on the back-end to easily re-login a user.

https://github.com/AscendingCreations/AxumCSRF

To handle Secure forms and to prevent Tampering with Forms and Cookies. Generally people say it is no longer needed but it is always good to have extra tamper protection. Still need to revamp and add more configuration to this though.

feel free to help out and check these libraries out.

genusistimelord commented 2 years ago

this has been fixed in https://github.com/AscendingCreations/AxumSessions/commit/374b7546ff95719e949be37389fc80af553835b7