search

AscendingCreations / AxumSession

Axum Session Management Libraries that use Sqlx
MIT License
144 stars 30 forks source link

Propsal changes to methods in SessionID #89

Open chungwong opened 2 weeks ago

chungwong commented 2 weeks ago

At this moment, SessionID has

pub fn inner(&self) -> String

pub fn uuid(&self) -> Uuid

I believe most of the time, what inner means it the type inside. However, it is not that case for SessionID.

Does it make sense if SessionID has the following instead?

pub fn to_string(&self) -> String

pub fn inner(&self) -> Uuid
genusistimelord commented 2 weeks ago

You are correct, I do have them backwards XD. If you like, I would accept a PR to change those. just make sure to add in the Readme the changes =3